From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage) Date: Sun, 29 Sep 2024 15:43:37 +0300 Message-ID: <86ldza4oli.fsf@gnu.org> References: <874jsngod2.fsf@tetzco.de> <83tu0nynla.fsf@gnu.org> <873586d7ii.fsf@tetzco.de> <834jsmpqf9.fsf@gnu.org> <87bkmua51z.fsf@tetzco.de> <83v8l2o212.fsf@gnu.org> <878rhut6aq.fsf@tetzco.de> <87ilgxs8vl.fsf@tetzco.de> <878rhts69s.fsf@tetzco.de> <87pmb5qiwv.fsf@tetzco.de> <87bkmpf87t.fsf@igel.home> <87o74696he.wl-herbert@gojira.at> <86seti4xks.fsf@gnu.org> <86plom4v3s.fsf@gnu.org> <87jzeu8xl8.wl-herbert@gojira.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37639"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de To: "Herbert J. Skuhra" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 14:44:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sutI8-0009eg-DS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 14:44:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sutHv-000721-6r; Sun, 29 Sep 2024 08:44:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sutHt-00071S-Av for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:44:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sutHs-0001JE-QY for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:44:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=EZ2/iohp7N6ByBB5vlx0dxmTUuIQG6B7VI74I9kDUeQ=; b=QUsojEPnDQORpeOLcwbX+6biYjGmhTcbbvsUn2OIiUsoWF4z9OmMg4W/wMqvT6PKVN4lylJJ6pKIvknKr4YVPN0tJ/j8vwjnCL7lHAffTBR31PkyKOUawTBaqDPom57lEn3HzJ95RvGaImh5PsDUl3fq4VN611y9dklIAzxtgv1jc1fb7FvkD6I3/FOrhdeehimKHfmv+z5GqUD3VqbBO6c6J8wzjhypc1539X8wBQsXi4vpnBeqYgCeKrgXP+A0XEpPNLSm85hQv597jdjAco2AqMDVokaMtnrewvKrN8Ufm5cGGZn5vZs9aSPD2wq/IRQUlB38XvuAKXe66+43eg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sutIN-0006mL-N6 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 12:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54154-submit@debbugs.gnu.org id=B54154.172761386625660 (code B ref 54154); Sun, 29 Sep 2024 12:45:03 +0000 Original-Received: (at 54154) by debbugs.gnu.org; 29 Sep 2024 12:44:26 +0000 Original-Received: from localhost ([127.0.0.1]:40233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sutHj-0006fM-0I for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:44:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sutHf-0006dd-DV for 54154@debbugs.gnu.org; Sun, 29 Sep 2024 08:44:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sutH4-0001FO-25; Sun, 29 Sep 2024 08:43:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EZ2/iohp7N6ByBB5vlx0dxmTUuIQG6B7VI74I9kDUeQ=; b=YEshIk+w7KGC TvDOa8EfeVQLdlP9OyUdiaRZttv2HJrxsJCn1aPeOCJjLkhqv8uG/BHEqXwxubE6IAwM+LPHYtOgc CrNmlYr+ASBFx1SDJ70cfHy9w24wPy9+VpNC9iayaVxNf7VXvsdduvuMHgn0wC3GoAOYc6Tg8+YH/ rfb5QGQ6lQT6bKvjKcWjzrakY3RGkigq6C3buwlWhlEnq12HiZln+P84TP60WOYnu/8nXRQiPyiOb lxMrQfSM87Y5Oj0WgIq+d8kcn5HGEAy0LjA3n3KztFsODT3g9jllQJC7l5cwhONwihCWan7ZAR2Ry cEep8q0KiLxvVjsNcQl/Zw==; In-Reply-To: <87jzeu8xl8.wl-herbert@gojira.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292636 Archived-At: > Date: Sun, 29 Sep 2024 14:15:47 +0200 > From: "Herbert J. Skuhra" > Cc: larsi@gnus.org, > 54154@debbugs.gnu.org, > emacs+bug@tetzco.de > > On Sun, 29 Sep 2024 12:23:03 +0200, > Eli Zaretskii wrote: > > > > > Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de > > > Date: Sun, 29 Sep 2024 12:29:39 +0300 > > > From: Eli Zaretskii > > > > > > > - Run emacs -Q > > > > - M-x sieve-manage > > > > - Input IMAP server (e.g. imap.mailbox.org) > > > > > > > > Debugger entered--Lisp error: (wrong-type-argument stringp t) > > > > sieve-manage--append-to-log("sieve-manage: Connecting to imap.mailbox.org..." "\n") > > > > sieve-manage--message("Connecting to %s..." "imap.mailbox.org") > > > > sieve-manage-open("imap.mailbox.org" nil) > > > > sieve-open-server("imap.mailbox.org" nil) > > > > sieve-manage("imap.mailbox.org") > > > > funcall-interactively(sieve-manage "imap.mailbox.org") > > > > command-execute(sieve-manage record) > > > > execute-extended-command(nil "sieve-manage" "sieve-ma") > > > > funcall-interactively(execute-extended-command nil "sieve-manage" "sieve-ma") > > > > command-execute(execute-extended-command) > > > > > > > > On 2nd try it works! > > > > > > The fix was not merged to the-then master branch, so it is not in > > > Emacs 30. Therefore, it is not a surprise you still see the problem: > > > it was only fixed in Emacs 29. > > > > > > I lost the context long ago, so I hope Kai will suggest how to handle > > > this. > > > > However, it's quite possible that the following band-aid should fix > > this particular issue: > > > > diff --git a/lisp/net/sieve-manage.el b/lisp/net/sieve-manage.el > > index 0faeb02..da2167c 100644 > > --- a/lisp/net/sieve-manage.el > > +++ b/lisp/net/sieve-manage.el > > @@ -178,7 +178,8 @@ sieve-manage--append-to-log > > (with-current-buffer > > (get-buffer-create sieve-manage-log) > > (set-buffer-multibyte nil) > > - (buffer-disable-undo))) > > + (buffer-disable-undo) > > + (current-buffer))) > > (goto-char (point-max)) > > (apply #'insert args)))) > > Yes, this works. Thanks. Thanks, installed on the emacs-30 branch. > As manage-sieve logs credentials maybe logging should be disabled by > default and/or credentials shouldn't be logged when logging is > enabled? I'll let Kai and others comment on that.