From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74905: [PATCH] Implement search for nnvirtual Gnus groups Date: Thu, 19 Dec 2024 04:51:24 +0530 Message-ID: <86ldwcziff.fsf@gmx.net> References: <86zfktesxb.fsf@gmx.net> <87bjx96ln5.fsf@thaodan.de> <86pllozkq4.fsf@gmx.net> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2083"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74905@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 19 00:22:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tO3NG-0000Nc-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Dec 2024 00:22:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tO3Mj-0007jv-JL; Wed, 18 Dec 2024 18:22:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tO3Mh-0007jh-PM for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2024 18:22:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tO3Mh-0007z9-8y for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2024 18:22:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ZsqUitlTWRA5+nF6yCrd9WPS3WfD4RS2hSlGOLNQyMQ=; b=rYseKHrIqUzfC31fIk71Ex06rz6A1He5MLs51z0x8p2C8VRdprFv9uxv6Tl9g0Corcpfi2C6GdENFsyRtHunUukxSJVzsnhN0nE4D/WdpgU5sv3Wk49PDLr5GLdLTTGlH05yJkpD+YN+/UfS9vJZRJRDyi4pFqhWj272s7ZWtvwy4rq3szeiFEiuU5RcU2fTc9+7S5qd+wv4K4rmRiH0cwEL9wvUAkoHpzZYVdSjfa8uk9N/YuOFJCHBDNFE82gk4YgLprEoDOMOoePSXAbzNFEjCJOhOfm3tDK0AouChLTEih08OwIXV3vtcWwBgv15LGK2RwaZPTtEQtOkZK/SnQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tO3Mf-0007Vs-U5 for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2024 18:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2024 23:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74905-submit@debbugs.gnu.org id=B74905.173456410028837 (code B ref 74905); Wed, 18 Dec 2024 23:22:01 +0000 Original-Received: (at 74905) by debbugs.gnu.org; 18 Dec 2024 23:21:40 +0000 Original-Received: from localhost ([127.0.0.1]:36423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO3MK-0007V3-7w for submit@debbugs.gnu.org; Wed, 18 Dec 2024 18:21:40 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:41923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO3MI-0007Un-F5 for 74905@debbugs.gnu.org; Wed, 18 Dec 2024 18:21:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1734564091; x=1735168891; i=jimjoe@gmx.net; bh=ZsqUitlTWRA5+nF6yCrd9WPS3WfD4RS2hSlGOLNQyMQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=rHAS+ujX/YhGqAmgG+1X8z9Ig+RmUkK/s38l8vm9kXD4sr/sAhM7PdUK0PRH/3CQ WH1FrdJ7NevbI3SGcDStNR8v6utarjfse0QfEtDOFrJc3/mfk/K+W1URZ4V+NsIZr BC2tnmN26lbHGh2iO1iSV4qSzaxa0YafgGSViYzX61GwESKMT0qVdLuIpkDR86+ih QrJcvk7uVIE+Q6IIn5Rr0PSY1eHdik2gMgIoMh/Rl+cVGsbX3usCYcY3vEMk3eVxg LuqtqVTrZADCnR6bjLtprfF9m5suQe67aTm4CHKmDcA36mKNAeyq1Qj70+9ZOp3rX iNWGmiYbvO5xnHUGWg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([42.104.189.106]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mkpf3-1tr62Q3U5P-00lRKy; Thu, 19 Dec 2024 00:21:30 +0100 In-Reply-To: <86pllozkq4.fsf@gmx.net> (James Thomas's message of "Thu, 19 Dec 2024 04:01:47 +0530") X-Provags-ID: V03:K1:eI0dxMqz3D0h2X4YogX4NZYFgoVImRnMbLiohdjdmnfZq6GJO+d 1j5IlAZIkTaaupS1HfbI1HyjDkdmoZx3vIdVmOsnEoYZ1xtF5cxWqnLMiBJYhXHHp55/cGw 3iNxqYZYLitpmecKWte4boVq4TfBaAlFZpZpAuOToAIidk4Du1Hg17LiN/+UbzVK1NwGm+7 3To2RRLWsnwPGddDZV/KA== UI-OutboundReport: notjunk:1;M01:P0:ny//z0OTucI=;3qHUysJDSKbHdTuBW3ljxuIEAPb hSrZJlrVoIb26HStoIzi/fY76Mh6iNxtARLPDhe6SuCqiWOqQCXidIIcXiFPr7ULMfrIrTrXH MnKh3DwQwH3aEOHSmPYtLbiYXghbvGHJgECjsRtAvyQ8M8zLQA721gVf7k2ucxY/5T8dgTelX d89NewjlGuHltNPJ9C4w4IT9TtR+Mz3sZUu7hRfgm8NtTvwjLfT4H7wJ3nbmCqtYF5otYw5GP 3iE+7yxxsjPrh3EuAy2Y11Js+iLxzITbKzkqKu81FnSP5CAmu+YbTxEVNQXQM/i5hhzQWmkhV 5OvllEAGkXwOaaVakOOdtDATmK0dkrMJQ5T2GuOrmorTGPpMnxqD+z55YpxsWIprB+v7qdYqa h0GqArLoh6D097k0LzXbAqzj4ZWK1P9xfCsb2a7E17gFAfP8cuWWfEiJ114C/tOH6kLo6y6pp 88nae1UrTz7nyst8bVR+EksQ8/fcyXHibw7Qxj+mZMN9JDEeJ2+OUzHKOhflArUFU938YaggG oBJJIrOkNxuNzsN0kNQE5Vi4u12UYBAwT+qiFt445cPoq/664FJ6dm9+4tGz9NXoh6dljTLD4 Q/zZXSZ9qq27l5PRHhDe9wBRA9HbLE7/cBwG79hW8o0sJIPKxvIbqB+g1qoiTD2AdCEs8B1Hw yH1MPSySgYs5vA2/j9+G8gVDovvh01tHjyiYECy/sM520ExoN99QkvcIaiBXm+u/5sQ4KcE37 F0HLd83Q0Ad5+d+Cwo33izikdGDLK6ZHVMg05Fgxht5NpDqVQlYo2qS7o0xncad0gq2M5ZTM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297352 Archived-At: James Thomas wrote: > Bj=C3=B6rn Bidar wrote: > >> James Thomas writes: >> >>> Bj=C3=B6rn Bidar wrote: >>> >>>> This patch implements search for nnvirtual. I'm using >>>> publi-inbox's >>>> with nnvirtual to group each group into one. >>>> However searching wasn't possible in these nnvirtual groups. >>>> I implemented gnus-search-run-search based on the existing >>>> nnselect gnus-search-run-search function. >>> >>> Thanks! I haven't looked into it, but here are some quick comments: >>> >>>> I'm looking for feedback on the patch. I don't exactly know how >>>> the search function is called when multiple groups of the same >>>> type >>>> are >>>> involved. For nnvirtual each group is its on server, does that >>>> mean >>>> the >>>> function will be always called only for each group? In that case >>>> everything should be good. >>> >>> That seems to be the case: see >>> gnus-group-read-ephemeral-search-group >>> and gnus-group-make-search-group. >> >> OK good than my understanding from my tests matched with the rest of >> the >> code. >> Thanks for these examples I haven't looked at the create group >> functions >> as the searched methods don't have to create groups even when they >> start >> a new search by another backend just like e.g. if the user would >> call >> a >> search on another imap group. >> >>>> +(deffoo nnvirtual-request-list (&optional server) >>>> + (when (nnvirtual-possibly-change-server server) >>>> + (with-current-buffer nntp-server-buffer >>>> + (erase-buffer) >>>> + (dolist (group nnvirtual-component-groups) >>>> + (insert (format "%S 0 1 y\n" group)))) >>>> + t)) >>> >>> Did you check if gnus-start.el#L1801 withstands this? It seems to >>> me >>> to >>> assume that nnvirtual doesn't have -request-list. >> >> It does. If the user has falsely add nnvirtual to one of the select >> methods than it will call it try to call the function which doesn't >> fail >> or do anything. The only thing that happens from that is it will >> show >> the false results as groups contained in the nnvirtual method >> without >> a >> parameter. > > No, I mean, the point of that code seems to be that nnvirtual is > activated _last_, i.e. after any component groups of other backends. No, sorry, I was a little confused about this. But it seems to me that -request-group removes each group from the component list (unlike your -request-list). Is that relevant? IDK. The latter seems to do info updation as well, based on -always-rescan. --