From: Juri Linkov <juri@linkov.net>
To: Visuwesh <visuweshm@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 55977@debbugs.gnu.org
Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Wed, 15 Jun 2022 10:25:03 +0300 [thread overview]
Message-ID: <86k09i5qy8.fsf@mail.linkov.net> (raw)
In-Reply-To: <87zgif15i9.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:39:34 +0530")
close 55977 29.0.50
thanks
>>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>>> for non-nil value of command bound to key; will attach patch once I get
>>>> the bug number.
>>>
>>> Thanks, but can you please show a recipe from "emacs -Q", to
>>> understand better what problem are you trying to fix?
>>
>> Sure.
>>
>> 1. M-x repeat-mode RET.
>> 2. C-h n.
>> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>> 4. C-c @ C-n. Notice how the help message still says C-n despite
>> being unbound, and when you type C-n the repeat map exits
>> contrary to what the message says.
>
> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
> C-n is no longer displayed in the help message.
Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key,
so now your patch is pushed to master, thanks.
next prev parent reply other threads:[~2022-06-15 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 17:27 bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Visuwesh
2022-06-14 17:30 ` Visuwesh
2022-06-14 17:40 ` Eli Zaretskii
2022-06-14 18:02 ` Visuwesh
2022-06-14 18:09 ` Visuwesh
2022-06-15 7:25 ` Juri Linkov [this message]
2022-06-15 7:36 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k09i5qy8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=55977@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).