From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Mon, 05 Jun 2023 09:50:44 +0300 Organization: LINKOV.NET Message-ID: <86jzwipf4z.fsf@mail.linkov.net> References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , 63648@debbugs.gnu.org, Spencer Baugh To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 09:06:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q64IC-0007SL-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 09:06:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q64I0-0000n2-K9; Mon, 05 Jun 2023 03:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q64Hy-0000mY-PG for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q64Hy-0007w9-HE for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q64Hy-0000EZ-Bb for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.1685948762894 (code B ref 63648); Mon, 05 Jun 2023 07:06:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 5 Jun 2023 07:06:02 +0000 Original-Received: from localhost ([127.0.0.1]:47885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q64Hx-0000EK-Fc for submit@debbugs.gnu.org; Mon, 05 Jun 2023 03:06:01 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q64Hu-0000E0-CW for 63648@debbugs.gnu.org; Mon, 05 Jun 2023 03:05:59 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D4D0EFF80E; Mon, 5 Jun 2023 07:05:49 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 02 Jun 2023 13:07:28 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262991 Archived-At: >> And indeed with the following patch replacing the current definition of >> 'project-switch-project' with just: >> >> (defun project-switch-project (dir) >> (interactive (list (funcall project-prompter))) >> (setq next-default-directory dir)) > > This would be a new "prefix command", like the `universal-argument`, > `C-x RET c`, the `ofw-other-window`, vc-edit-next-command, > `ofw-other-frame` from the `other-frame-window` package, and a few more. > > In order for this new prefix to interact correctly with those other > ones, it should probably use `prefix-command-preserve-state` and it > would be good to make it show some visual feedback via > `prefix-command-echo-keystrokes-functions`. Here is the same function turned into a prefix command, so it supports both cases: 1. 'C-x p p d' -- keys from project-prefix-map 2. 'C-x p p C-x d' -- global keybindings ``` (defun project-switch-project (dir) (interactive (list (funcall project-prompter))) (if (symbolp project-switch-commands) (let ((default-directory dir)) (call-interactively project-switch-commands)) (let* ((echofun (lambda () "[switch-project]")) (postfun (lambda () (remove-hook 'prefix-command-echo-keystrokes-functions echofun)))) (setq next-default-directory dir) (add-hook 'prefix-command-echo-keystrokes-functions echofun) (message (project--keymap-prompt)) (prefix-command-update) (set-transient-map project-prefix-map nil postfun)))) ``` If this is conceptually ok, then more customization could be ported from project--switch-project-command such as project-switch-use-entire-map.