From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68815: Unexpected behavior with read-file-name and functional REQUIRE-MATCH argument Date: Thu, 01 Feb 2024 08:59:24 +0200 Message-ID: <86jzno1xgz.fsf@gnu.org> References: <8734ufyxoy.fsf@breatheoutbreathe.in> <87ttmuhvxi.fsf@breatheoutbreathe.in> <875xz98975.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, philipk@posteo.net, 68815@debbugs.gnu.org, joseph@breatheoutbreathe.in To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 08:00:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVR3V-0000aW-Py for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 08:00:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVR3C-0005Q6-6b; Thu, 01 Feb 2024 01:59:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVR3A-0005Pp-RE for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 01:59:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVR3A-00048t-Iz for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 01:59:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVR3K-00068f-8W for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 02:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68815 X-GNU-PR-Package: emacs Original-Received: via spool by 68815-submit@debbugs.gnu.org id=B68815.170677078623541 (code B ref 68815); Thu, 01 Feb 2024 07:00:02 +0000 Original-Received: (at 68815) by debbugs.gnu.org; 1 Feb 2024 06:59:46 +0000 Original-Received: from localhost ([127.0.0.1]:40105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVR33-00067c-O2 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 01:59:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVR31-00067Q-Iu for 68815@debbugs.gnu.org; Thu, 01 Feb 2024 01:59:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVR2j-000462-UD; Thu, 01 Feb 2024 01:59:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kHEXvv/4yBq+jzk6TtNtn1iPfrpUfY0ZsUI1P6fHH9g=; b=ONLKlh4TyJc/ wQ4s/HQeZ03kyAaUa1E9RRtrkErmPgldLf98cnNZhrJTkn6hxE0gVXEUxyNK1XVXIbTx+Juu4s5wW gs1+Ox3Z5AkYlvy+BEo64ygzIBeMFA9EoLNm09yM+NzAE4tD5CpUlpVUAH/CfAu13+yr/Kc7/d+a1 CyCtR1K4RhCcuChf+3pePVmn5AmJX4VxTkQoZbPY49MqRzVeVxqIIPvTk+i7GGsKeH4MEdiz+OZRL sJC3JImG2j+R9B02i3EXa+JXsJ3ej2NktStnF4+mfO+mUQyBcmCJoH3nFPMlb1LypTcsZfJxcB/Qt wLZazFmQOQmOys1SOHtOPw==; In-Reply-To: (message from Stefan Monnier on Wed, 31 Jan 2024 17:05:30 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279261 Archived-At: > From: Stefan Monnier > Cc: 68815@debbugs.gnu.org, Philip Kaludercic , > michael_heerdegen@web.de, Eli Zaretskii > Date: Wed, 31 Jan 2024 17:05:30 -0500 > > >> Also, performance can be a concern (in many cases it makes more sense > >> to make the caller pass the unquoted name rather than force it to quote > >> the name only for PRED to unquote it). > > > > The REQUIRE-MATCH function is only called once when the user attempts to > > exit the minibuffer. Would you please explain the performance concern? > > Oh, sorry, I got confused. Indeed, you're wrapping the REQUIRE-MATCH > arg, not the PRED arg I was ranting about. Duh! > > It would be OK for `emacs-29`, indeed. Eli? Stefan? Any objection? I don't mind, but please note that I'm not sure there will be any further 29.x releases. > In the mean time, could you update the docs to clarify the behavior. Yes, please.