From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66151: 29.1.50; daemon crashing after X forwarding disconnects Date: Fri, 19 Apr 2024 14:15:39 +0300 Message-ID: <86jzktbo2s.fsf@gnu.org> References: <87jzl63rhd.fsf@yahoo.com> <87cyqw4ta9.fsf@yahoo.com> <874jc63u8a.fsf@yahoo.com> <87r0f932qz.fsf@yahoo.com> <86sezjdkdk.fsf@gnu.org> <87r0f1iuuw.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66151@debbugs.gnu.org, georgepanagopo@gmail.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 19 13:17:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxmEp-0009nv-LK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Apr 2024 13:17:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxmEf-0006Oe-Eg; Fri, 19 Apr 2024 07:16:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxmEd-0006OA-KT for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:16:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxmEd-0003Tr-Bw for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:16:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxmEq-0007bD-ON for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:17:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2024 11:17:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66151 X-GNU-PR-Package: emacs Original-Received: via spool by 66151-submit@debbugs.gnu.org id=B66151.171352536628802 (code B ref 66151); Fri, 19 Apr 2024 11:17:04 +0000 Original-Received: (at 66151) by debbugs.gnu.org; 19 Apr 2024 11:16:06 +0000 Original-Received: from localhost ([127.0.0.1]:58092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxmDu-0007US-Bl for submit@debbugs.gnu.org; Fri, 19 Apr 2024 07:16:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxmDr-0007T7-3H for 66151@debbugs.gnu.org; Fri, 19 Apr 2024 07:16:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxmDW-0003MM-Ti; Fri, 19 Apr 2024 07:15:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oPfJawuwqyJO0Jq2O9ZX3Z04zCWcQkoDtP66bGuTvqw=; b=rktsa0B9Yvt/ V+VuZzkS21XY4tDGoned3i3/yOy35m0oQmzgNgybg5vX9pHhpBFWGjAwv7y66AG4Tb0WgPjA4X1PY 35xCiFnOoJNCxUil/jyN4EC85o9f5l+8L42aRvcG1mJe42kKV4fMiIlBvAKZprM6Ksu/DDF9zgMSP HwmDNc0BJJPRb9SWFoPlnDFPsknkWg/hTv538oo7wKv2lNCWv9E+oEnwIb24WI2hDqEI1EJbm/8sM BxgVreGMDzzlc2BB9VdNR6NPvF+PsTb29043BOABxhOvWbLaOmf9QZIeX9bsCuZ4j+frkr8c7U/YX 52Joa1KQ7Btx7qzh/Jr6tg==; In-Reply-To: <87r0f1iuuw.fsf@yahoo.com> (message from Po Lu on Fri, 19 Apr 2024 17:07:19 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283665 Archived-At: > From: Po Lu > Cc: George P , 66151@debbugs.gnu.org > Date: Fri, 19 Apr 2024 17:07:19 +0800 > > Eli Zaretskii writes: > > > Po Lu, how should we go about making some progress here? > > Thanks. My hands are quite full and will remain so into the next week, > but if this crude attempt to sidestep the crash works, it should suffice > until I establish why dead frames are still being retained in > Vfontset_table. George? > > diff --git a/src/fontset.c b/src/fontset.c > index d27fa22015e..d969e5f1180 100644 > --- a/src/fontset.c > +++ b/src/fontset.c > @@ -1366,10 +1366,11 @@ free_realized_fontsets (Lisp_Object base) > if (CHAR_TABLE_P (this) && EQ (FONTSET_BASE (this), base)) > { > Fclear_face_cache (Qt); > - /* This is in case some Lisp calls this function and then > - proceeds with calling some other function, like font-at, > - which needs the basic faces. */ > - recompute_basic_faces (XFRAME (FONTSET_FRAME (this))); > + if (!FRAME_LIVE_P (XFRAME (FONTSET_FRAME (this)))) > + /* This is in case some Lisp calls this function and then > + proceeds with calling some other function, like font-at, > + which needs the basic faces. */ > + recompute_basic_faces (XFRAME (FONTSET_FRAME (this))); > break; > } > } Are you sure it should be !FRAME_LIVE_P ? Why would we condition the call to recompute_basic_faces on the fact that the relevant frame is no longer alive? What am I missing?