From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 49731@debbugs.gnu.org
Subject: bug#49731: 28.0.50; Filter xref results by filename
Date: Tue, 04 Jun 2024 09:34:24 +0300 [thread overview]
Message-ID: <86jzj5i5mh.fsf@mail.linkov.net> (raw)
In-Reply-To: <86v86s4dsi.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 13 Feb 2024 18:52:29 +0200")
> Also there is an additional helper function that is needed
> to keep hidden outlines and restore them after reverting the
> xref buffer with 'g' (xref-revert-buffer).
> This is an example of advice that does this.
> Later when xref will use revert-buffer-function,
> this advice could be replaced by a simple hook call:
>
> #+begin_src emacs-lisp
> (define-advice xref-revert-buffer (:around (ofun &rest args) keep-outlines)
> "Keep hidden outlines after xref revert."
> (let ((regexp (outline-hidden-headings-regexp))
> (value (apply ofun args)))
> (outline-hide-by-heading-regexp regexp)
> value))
> #+end_src
So here is the patch for xref:
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 0025f1f9479..0a5c9243027 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1277,13 +1277,18 @@ xref-revert-buffer
"Refresh the search results in the current buffer."
(interactive)
(let ((inhibit-read-only t)
- (buffer-undo-list t))
+ (buffer-undo-list t)
+ restore-functions)
+ (when (boundp 'revert-buffer-restore-functions)
+ (run-hook-wrapped 'revert-buffer-restore-functions
+ (lambda (f) (push (funcall f) restore-functions) nil)))
(save-excursion
(condition-case err
(let ((alist (xref--analyze (funcall xref--fetcher)))
(inhibit-modification-hooks t))
(erase-buffer)
- (xref--insert-xrefs alist))
+ (prog1 (xref--insert-xrefs alist)
+ (mapc #'funcall (delq nil restore-functions))))
(user-error
(erase-buffer)
(insert
next prev parent reply other threads:[~2024-06-04 6:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1pmv6iz4n.fsf.ref@yahoo.es>
2021-07-25 8:19 ` bug#49731: 28.0.50; Filter xref results by filename Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 8:32 ` Lars Ingebrigtsen
2021-07-25 8:33 ` Lars Ingebrigtsen
2021-07-26 23:16 ` Dmitry Gutov
2021-07-25 9:10 ` Eli Zaretskii
2021-07-25 14:58 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 20:43 ` Juri Linkov
2021-07-26 11:49 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-26 22:53 ` Juri Linkov
2022-01-16 18:52 ` Juri Linkov
2022-11-21 7:58 ` Juri Linkov
2022-11-23 8:39 ` Juri Linkov
2022-11-23 14:19 ` Dmitry Gutov
2022-11-23 17:50 ` Juri Linkov
2022-11-23 18:08 ` Dmitry Gutov
2022-11-23 18:20 ` Juri Linkov
2022-11-23 18:47 ` Dmitry Gutov
2022-11-24 7:48 ` Juri Linkov
2022-11-25 7:35 ` Kévin Le Gouguec
2024-02-13 16:52 ` Juri Linkov
2024-02-14 9:25 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15 7:23 ` Juri Linkov
2024-06-03 17:18 ` Juri Linkov
2024-06-04 6:34 ` Juri Linkov [this message]
2024-06-05 6:36 ` Juri Linkov
2021-07-26 23:28 ` Dmitry Gutov
2021-07-27 17:08 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-27 20:51 ` Juri Linkov
2021-07-27 23:11 ` Dmitry Gutov
2021-07-28 0:08 ` Dmitry Gutov
2021-07-28 16:12 ` Juri Linkov
2021-07-29 2:02 ` Dmitry Gutov
2021-07-29 17:43 ` Juri Linkov
2021-08-02 2:09 ` Dmitry Gutov
2021-08-02 20:58 ` Juri Linkov
2021-08-06 0:03 ` Dmitry Gutov
2021-07-31 16:45 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-31 17:06 ` Eli Zaretskii
2022-11-23 18:48 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzj5i5mh.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=49731@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).