unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ke Wu <ellpih@zohomail.jp>
Cc: 71472@debbugs.gnu.org
Subject: bug#71472: [PATCH] Add pty support by using ConPTY on Windows
Date: Mon, 10 Jun 2024 18:40:48 +0300	[thread overview]
Message-ID: <86jziw956n.fsf@gnu.org> (raw)
In-Reply-To: <874ja1m6u1.fsf@zohomail.jp> (message from Ke Wu on Mon, 10 Jun 2024 18:26:46 +0800)

> From: Ke Wu <ellpih@zohomail.jp>
> Date: Mon, 10 Jun 2024 18:26:46 +0800
> 
> This patch adds pty support by using ConPTY on Windows. The conhost.exe
> runs in pty mode and provides pty interface. The package term is also
> patched to make it usable on Windows.

Thanks.  It's a pity you didn't discuss this before working on the
code, because ConPTY is not very useful on MS-Windows due to the
limitations of its encoding.  See this issue I opened 3 years ago, and
which they meanwhile closed (I guess they don't plan on fixing this
anytime soon).  See

  https://github.com/microsoft/terminal/issues/9174

If we must use UTF-8 as the only encoding to talk to sub-processes via
ConPTY, that makes the number of applications that can be used this
way very small, since most programs we are used to run as
subprocesses, in particularly ports of GNU software like GCC, GDB,
Grep, Find, and many others, cannot reliably talk to Emacs in UTF-8
encoding on MS-Windows.  And without that, what would we use this
feature for?

So unfortunately, I don't think we should install these patches.





  reply	other threads:[~2024-06-10 15:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 10:26 bug#71472: [PATCH] Add pty support by using ConPTY on Windows Ke Wu
2024-06-10 15:40 ` Eli Zaretskii [this message]
     [not found]   ` <190055cd3c0.5289e49215028.2058921479589116968@zohomail.jp>
2024-06-11  7:27     ` Eli Zaretskii
2024-06-11  8:24       ` Ke Wu
2024-06-11  8:42         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jziw956n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71472@debbugs.gnu.org \
    --cc=ellpih@zohomail.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).