From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Spencer Baugh <sbaugh@janestreet.com>,
Eli Zaretskii <eliz@gnu.org>,
joaotavora@gmail.com, 71823@debbugs.gnu.org
Subject: bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line
Date: Sun, 30 Jun 2024 09:50:36 +0300 [thread overview]
Message-ID: <86jzi7q71j.fsf@mail.linkov.net> (raw)
In-Reply-To: <5782856d-9c8f-4903-9d42-143a015fee14@gutov.dev> (Dmitry Gutov's message of "Sat, 29 Jun 2024 14:59:10 +0300")
>> After all, the project-mode-line
>> option belongs to project.el, so the fact that it adds the project
>> name to the mode line too indiscriminately can legitimately be
>> considered to be a problem with that option. Right?
>
> It's "discriminate" and off by default.
>
>> On top of that,
>> project-mode-line is new in Emacs 30, whereas Eglot has been showing
>> the project in its mode line before that. So once again, IMO the onus
>> is on project.el to fix this somehow. For example, by not adding this
>> to the mode line in Eglot-controlled buffers.
>
> Hard-coding an "unless Eglot" condition seems like a bad idea in terms of
> abstraction and general code logic.
I completely agree. When a user explicitly expressed the wish
to display the project name in the middle of the mode line by
customizing project-mode-line to t, this means there is no need
to duplicate it at the end of the mode line with Eglot information.
This will make the mode line shorter.
Ideally, everything should be customizable by two new Eglot options:
eglot-mode-line-format and eglot-mode-line-position (e.g. middle/end).
next prev parent reply other threads:[~2024-06-30 6:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 14:13 bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line Spencer Baugh
2024-06-28 14:15 ` Spencer Baugh
2024-06-28 14:40 ` Eli Zaretskii
2024-06-28 17:49 ` João Távora
2024-06-28 22:08 ` Spencer Baugh
2024-06-29 7:12 ` Eli Zaretskii
2024-06-29 11:59 ` Dmitry Gutov
2024-06-29 12:43 ` Eli Zaretskii
2024-06-30 6:50 ` Juri Linkov [this message]
2024-06-30 10:25 ` João Távora
2024-06-29 12:05 ` João Távora
2024-06-29 12:17 ` Dmitry Gutov
2024-06-29 12:21 ` João Távora
2024-06-29 12:41 ` Spencer Baugh
2024-06-29 14:24 ` Spencer Baugh
2024-06-30 0:25 ` João Távora
2024-06-30 12:51 ` sbaugh
2024-06-30 14:53 ` João Távora
2024-06-30 15:05 ` João Távora
2024-07-03 13:17 ` Spencer Baugh
2024-07-03 13:59 ` João Távora
2024-07-03 14:47 ` Spencer Baugh
2024-07-03 14:57 ` João Távora
2024-07-03 15:12 ` Spencer Baugh
2024-07-03 16:03 ` João Távora
2024-07-03 17:10 ` sbaugh
2024-07-05 12:04 ` João Távora
2024-07-15 13:30 ` Spencer Baugh
2024-06-30 16:38 ` Juri Linkov
2024-07-03 13:00 ` Spencer Baugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzi7q71j.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=71823@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).