From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72245: [PATCH] Fix integer overflow when reading XPM Date: Tue, 23 Jul 2024 20:54:52 +0300 Message-ID: <86jzhc8043.fsf@gnu.org> References: <87frs0ydv6.fsf@yahoo.com> <87bk2oyavb.fsf@yahoo.com> <86wmlc86ne.fsf@gnu.org> <87msm83t4r.fsf@igel.home> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4793"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 72245@debbugs.gnu.org, stefankangas@gmail.com To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 19:56:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWJkK-00013x-0j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 19:56:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWJkG-0002aW-7s; Tue, 23 Jul 2024 13:56:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWJjx-0002YV-Rf for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 13:56:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWJjx-0007PI-B0 for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 13:55:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWJk2-0005eX-0m for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72245-submit@debbugs.gnu.org id=B72245.172175730621649 (code B ref 72245); Tue, 23 Jul 2024 17:56:01 +0000 Original-Received: (at 72245) by debbugs.gnu.org; 23 Jul 2024 17:55:06 +0000 Original-Received: from localhost ([127.0.0.1]:60700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWJj8-0005d7-6c for submit@debbugs.gnu.org; Tue, 23 Jul 2024 13:55:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWJj7-0005bn-4S for 72245@debbugs.gnu.org; Tue, 23 Jul 2024 13:55:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWJiw-00073S-HB; Tue, 23 Jul 2024 13:54:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hssJ1uOZ80/KZhy14gmMin5b7DErFcPrwRXK59nHOfA=; b=GnpmFGXNQmCz SMV4s5bG9iIIh75Tco64N8ZttRNpTraKhnHf2PN7T5JjsdvdRXZS6w0vMBrzR7y7+m7XjaNl+UKGc zheXCrRN42c3A4SAuXU06Vh5Ws5Nhbbw+iHKtk+MReVioSp9zo4mmwoV+HqtFrTE0vte4aqxqIG7R 1NGHvNOTeNSZiPxMi2XQBiQLEVpeE6ZT1NJKKs0tz1eOTYR/X++zm1gtpMYSxDTwZ/F7dNPJYloa1 X7MRSYNObKzFM/0HmzUi2/za47wGJ90dW/GwuDGMS+F1pHo+/lhl1i/V/RNmpHsb7yEBzI23uppn+ KlTiyCZib8+yQGpPUn8ufA==; In-Reply-To: <87msm83t4r.fsf@igel.home> (message from Andreas Schwab on Tue, 23 Jul 2024 19:39:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289188 Archived-At: > From: Andreas Schwab > Cc: Stefan Kangas , luangruo@yahoo.com, > 72245@debbugs.gnu.org > Date: Tue, 23 Jul 2024 19:39:16 +0200 > > On Jul 23 2024, Eli Zaretskii wrote: > > > That file doesn't cause a crash on MS-Windows, FWIW, but the code > > which processes XPM images in Emacs on Windows is very different. > > The absence of a crash does not prove anything, though. It isn't the absence of a crash alone. I see an error message in *Messages* saying the XPM image is invalid, and the window shows an empty rectangle, as always with invalid images. So Emacs actually detects that the image is invalid, announces that, and doesn't try to show it on the screen.