From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73584: 29.3; read-key Date: Sun, 27 Oct 2024 12:30:02 +0200 Message-ID: <86jzdtaled.fsf@gnu.org> References: <56f7ea1fff72be793a8026baf34e1548@jovi.net> <86v7yb11wc.fsf@gnu.org> <86h69u22y8.fsf@gnu.org> <86v7y9zpqs.fsf@gnu.org> <86plo4tekx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9360"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73584-done@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Emacs-hacker2023@jovi.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 11:31:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t50YG-0002Fu-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 11:31:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t50XV-0003UR-3A; Sun, 27 Oct 2024 06:30:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t50XU-0003UA-2N for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:30:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t50XT-0004Je-Ev for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=pByEDZgEQe6qD6Rn0Dyy6xKvriKq1lfh1fUPOAFypZ0=; b=fSDbSlGA+uGhjVigHCi9sACNJMUYs4GOqEVqoKqKRZ6QCXr5UEyrOxswffIpiNaDZ8V6jiiIHhiTIfWNt2+jLmD+plCiH8U6X1DygMmOvD8wptgfgpOGfsW9fNG00IJJyQCfkqxmZHlSG0HeFPCBjtEt0FqejlMRcVONdl+6aGnQs07K9ABKxCvByyNAdYjIuPxrsW6Z1f0NB5v4/u2I69F1gYYv5WYdyd27xwwRZyplUGMEKi331Po8Os6jq2Jx2bjSQWagxseuBdTXWaX++r0SYBNDpOsxqu/eLZFtRJXNVmfS+eBqfl5RIrhAKCrzfIfcZ5q7/FL/1Db9uic34A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t50Y1-0006LE-WC for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:31:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73584 X-GNU-PR-Package: emacs Mail-Followup-To: 73584@debbugs.gnu.org, eliz@gnu.org, Emacs-hacker2023@jovi.net Original-Received: via spool by 73584-done@debbugs.gnu.org id=D73584.173002505024187 (code D ref 73584); Sun, 27 Oct 2024 10:31:01 +0000 Original-Received: (at 73584-done) by debbugs.gnu.org; 27 Oct 2024 10:30:50 +0000 Original-Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t50Xq-0006Hi-8K for submit@debbugs.gnu.org; Sun, 27 Oct 2024 06:30:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t50Xp-0006Eo-0V for 73584-done@debbugs.gnu.org; Sun, 27 Oct 2024 06:30:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t50XA-0004Hc-Aj; Sun, 27 Oct 2024 06:30:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pByEDZgEQe6qD6Rn0Dyy6xKvriKq1lfh1fUPOAFypZ0=; b=P5B3DoVs+I+H I5wU8QKiA/cTtIcvwSlmDSZwohm0OF12AiKOtEtMBtERW4gI26sZhCPRYwSrI0A8gk0qSxCHsX4v0 mOUqDWlgessOHO44WyEVLYqnU9z00q5j2mN99XwjH77QqBVz76TrZWY4OEtDFNUbqxWfFM/q0EpLy 385GFBmuwtJdlHG3etWMgKHvTEjIzl1CZRLo5JTn7N7LAZSWfXyZh0fsQwzwLmR8odmzstiA+M0Fx Gv29pcn4HcZ9ibq1OKtGc/hfixLLZZVm66SpnwKFeepX272Ef79FcdF2UJaOn2zZm7PVwMSNo+kmc ulQxZgf+4tE2LghSx3PXfw==; In-Reply-To: <86plo4tekx.fsf@gnu.org> (message from Eli Zaretskii on Sun, 13 Oct 2024 14:41:34 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294325 Archived-At: > Cc: 73584@debbugs.gnu.org, stefankangas@gmail.com, Emacs-hacker2023@jovi.net > Date: Sun, 13 Oct 2024 14:41:34 +0300 > From: Eli Zaretskii > > > From: Stefan Monnier > > Cc: Stefan Kangas , Emacs-hacker2023@jovi.net, > > 73584@debbugs.gnu.org > > Date: Thu, 03 Oct 2024 11:43:25 -0400 > > > > > The OP shot himself in the foot by invoking by hand a low-level > > > function with a wrong argument. Interactive functions and high-level > > > APIs must check their arguments right away, but low-level functions > > > like this one do not. > > > > I think the "bug" is indeed not in the fact that we check too late for > > a string. I guess we could say that any code which temporarily rebinds > > the global map should be super-extra careful never to signal an error, > > and prevent itself from being Edebugged etc... but it would be > > preferable for the debuggers to "handle it". > > Is the patch below acceptable as the solution to this? > > diff --git a/lisp/emacs-lisp/backtrace.el b/lisp/emacs-lisp/backtrace.el > index 120972d..e353970 100644 > --- a/lisp/emacs-lisp/backtrace.el > +++ b/lisp/emacs-lisp/backtrace.el > @@ -202,6 +202,7 @@ backtrace-mode-map > "+" #'backtrace-multi-line > "-" #'backtrace-single-line > "." #'backtrace-expand-ellipses > + "C-]" #'abort-recursive-edit > "" 'mouse-face > "" #'mouse-select-window No further comments within 2 weeks, so I've now installed this on the master branch, and I'm therefore closing this bug.