unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: julien@danjou.info, mattias.engdegard@gmail.com, noah@splode.com,
	74055@debbugs.gnu.org
Subject: bug#74055: 31.0.50; color-lighten-name not lightening black
Date: Sat, 02 Nov 2024 18:17:34 +0200	[thread overview]
Message-ID: <86jzdly5i9.fsf@gnu.org> (raw)
In-Reply-To: <m2ttcuydbx.fsf@gmail.com> (message from Gerd Möllmann on Tue, 29 Oct 2024 19:27:14 +0100)

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  julien@danjou.info,
>   74055@debbugs.gnu.org,  noah@splode.com
> Date: Tue, 29 Oct 2024 19:27:14 +0100
> 
> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> 
> > I'd say the old model (percentage points) is better because it results
> > in changes that are perceptually more uniform. For example, with the
> > current code,
> >
> >   (color-lighten-name C 5)
> >
> > has much less effect when C is a dark colour than for a light one.
> > Therefore the change was probably a mistake in hindsight.
> 
> +1

I hope I fixed that now, please take a look.

Noah's original example works as expected, and the comparison with Web
sites also seems to be working.





  reply	other threads:[~2024-11-02 16:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28  8:27 bug#74055: 31.0.50; color-lighten-name not lightening black Gerd Möllmann
2024-10-28 12:39 ` Eli Zaretskii
2024-10-28 15:18   ` Ship Mints
2024-10-28 16:57   ` Mattias Engdegård
2024-10-28 17:24     ` Eli Zaretskii
2024-10-29  4:41       ` Gerd Möllmann
2024-10-29  8:25         ` Gerd Möllmann
2024-10-29 12:54       ` Mattias Engdegård
2024-10-29 18:27         ` Gerd Möllmann
2024-11-02 16:17           ` Eli Zaretskii [this message]
2024-11-02 17:10             ` Gerd Möllmann
2024-11-04 12:35               ` Gerd Möllmann
2024-11-04 13:31                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jzdly5i9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74055@debbugs.gnu.org \
    --cc=gerd.moellmann@gmail.com \
    --cc=julien@danjou.info \
    --cc=mattias.engdegard@gmail.com \
    --cc=noah@splode.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).