From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Fri, 22 Nov 2024 10:20:59 +0200 Message-ID: <86jzcvof10.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> <86y11cnyws.fsf@gnu.org> <87iksfpwlr.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 22 09:22:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEOvv-0005ce-FQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Nov 2024 09:22:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEOvV-0007Pq-EY; Fri, 22 Nov 2024 03:22:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEOvT-0007Le-5W for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 03:22:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEOvS-0008Gk-Sx for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 03:22:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=a8slCnskuqqwx/yJBSHEn/g8KehTLWbZss0kCjyxFYA=; b=TiGjIs4GZjfh8uTZmAFM2w6buKn+iX71S0p4oJUJlU4lIWWK0Ld2uxfXepiQwubidQmVXEm53a0TwkZp5uxc51GTjSZwaS7oBAldGucyXS4lDfXW4UgG/yXd7u+ERnI1DmRZKk66fiCYIrBneEaheJZNKI9p4c9ZuPWXnzBDOYuDJ0XtWTi4GUO8zlNcbIFnBY6FDL0FTRqvw4rLvBkKB9Q/P0qu9+KDWlhVoMZg3LI+du1nQkjY/XX2W7x5J2D/HwuiAgEdRL7MOmH3vzvQdticRCRxKYrtRsAxktsesdX4y6wUdJbZd4eklEsjj70Ddg+kvJ2aa3f/JQoYoM4rdA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEOvS-0004wY-HE for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 03:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2024 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173226367518923 (code B ref 74361); Fri, 22 Nov 2024 08:22:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 22 Nov 2024 08:21:15 +0000 Original-Received: from localhost ([127.0.0.1]:52946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEOuh-0004v9-Cm for submit@debbugs.gnu.org; Fri, 22 Nov 2024 03:21:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEOud-0004us-9E for 74361@debbugs.gnu.org; Fri, 22 Nov 2024 03:21:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEOuV-0008FJ-VF; Fri, 22 Nov 2024 03:21:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=a8slCnskuqqwx/yJBSHEn/g8KehTLWbZss0kCjyxFYA=; b=Ou1wSuMAcBgF CRcfAxah7/PDPhD6Iw/uU/b//3J7SKdzUN4QUxjvidBsjjlPZCRZAyxKPcjfNeC+6mZFLGGnvK0hQ IodAXLcJ5LJ1y1TrEOy47TLO4svk+8xRACDurBmcVyrJCspStdyvZvZfsTsN1cKQOReI6k+t6XWDd BlZ73dGzkOzq1jj07a0i2ODGOHFMOnA+tXz/P51XQP9wj8vOHfCSGARaN8Z6UVCdI5qb/NGei8u8C 8M/boF2/XDYs088Cgb3AIQLvohvdP/c/0LQOFWyyPMQ9lie7PU1C/0NoQpyXmK+20dIKrwcBdFu/z PqL/+MzAw7bXctqOolvKNQ==; In-Reply-To: <87iksfpwlr.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 22 Nov 2024 09:29:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295779 Archived-At: > From: Juri Linkov > Cc: dmitry@gutov.dev, rudalics@gmx.at, 74361@debbugs.gnu.org > Date: Fri, 22 Nov 2024 09:29:00 +0200 > > >> cmuscheme.el: > >> (define-derived-mode inferior-scheme-mode comint-mode "Inferior Scheme" > >> ... > >> (pop-to-buffer "*scheme*" display-comint-buffer-action) > >> > >> inf-lisp.el: > >> (define-derived-mode inferior-lisp-mode comint-mode "Inferior Lisp" > >> ... > >> (pop-to-buffer "*inferior-lisp*" display-comint-buffer-action) > >> > >> shell.el: > >> (define-derived-mode shell-mode comint-mode "Shell" > >> ... > >> (pop-to-buffer buffer display-comint-buffer-action) > > > > Those are not the categories, those are the deprecated user options > > for which the categories are supposed to be a replacement we > > recommend: > > > > (make-obsolete-variable > > 'display-comint-buffer-action > > "use a `(category . comint)' condition in `display-buffer-alist'." > > "30.1") > > The categories are a replacement only for customization. > But all display-buffer calls should still contain > `(category . comint)' that currently presented > in these variables. IOW, the variables currently > are used in two ways: > 1. as the default values for display-buffer calls > 2. as user options > > But now customization is supposed to be only with > the help of `(category . comint)' in `display-buffer-alist'. > So these variable will be used only in display-buffer calls. > > > So if some user wants to take our advice and modernize his/her > > customizations to use '(category . comint)' instead of > > display-comint-buffer-action, the customization will stop working for > > him/her when we remove those obsolete options in some future Emacs > > version. Right? Or what am I missing? > > These are two possible solutions: > 1. Demote these options to variables not intended for customization. > 2. Move their current default values to display-buffer calls. I expected to see us do #2 at the same time we deprecated the user options. I don't understand why we didn't do that. The deprecation message clearly tells users not to use these variables, so it's reasonable to expect them to be deleted. Moreover, their presence in our sources is a potential cause for byte-compilation warnings.