From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 07 Dec 2024 11:54:00 +0200 Message-ID: <86jzcbkedj.fsf@gnu.org> References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86jzcdkx6t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26833"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 10:55:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJrWs-0006s8-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 10:55:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJrWi-0007qT-6W; Sat, 07 Dec 2024 04:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJrWg-0007ov-In for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 04:55:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJrWg-0000mX-9N for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 04:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=IF0i9bTQ8UR56vF2oOb6Td1ji0BI9D/1/3jEPOme3Yw=; b=m+FHSpqw5aRRTIuKyR3qmlKSKDFtefUfASkFQ3th7in/feB9ym7LWrV7IQ0RvMl3WbnzIQaUsTrRnJRuJhj8ayKq90vAkSe7Fo2ZXh83RKdDyKO42Vn0FeJtu5Vg2F/fBcWZOKtocke95Jp60mloErxosxbciLvvUIjbAc9hpBK7j+tQXS3hkxbIiDzcIMpz5g5ZIukOob5ur/Zqa2LJ6YOCT3HHRJKySq6oWLaQf0okh88RHbn4UFz1fX41ZOTru+JLac7anFcOQSO2d1lmm8sEOe9kvcQ7r/Qaw0acu+2FC0VKMKwiQBXDdQW9f36j1zzaLqC3RXNHBMj3ILqIRQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJrWg-0002es-4X for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 04:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173356525210131 (code B ref 73862); Sat, 07 Dec 2024 09:55:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 7 Dec 2024 09:54:12 +0000 Original-Received: from localhost ([127.0.0.1]:45435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJrVr-0002dJ-Ia for submit@debbugs.gnu.org; Sat, 07 Dec 2024 04:54:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJrVo-0002d1-RC for 73862@debbugs.gnu.org; Sat, 07 Dec 2024 04:54:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJrVi-0000hM-VN; Sat, 07 Dec 2024 04:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IF0i9bTQ8UR56vF2oOb6Td1ji0BI9D/1/3jEPOme3Yw=; b=ZRqO6HfEaSJ9RICzRwJJ pTNZbJXTFqFGT9vg5IY6V+KLVGP8IhArNwxHS9A3Fnv9Qjb1TdLh1WMcf+2xV2MZ2pW5A31+Lx0e1 l3QmZ3cVCmj77eksWLwl7Z9wJlJYKhYz0GX6fWgCYiQqCEjxEbQcxC7ftpahWOu6GncIXgty4TFhs mxTN8Am1QhrH0dteLWVWdsnnv/G30jL9Lx7PzeVhV0D43b5IBFCon3gU8C8sXD9J5Q+rB5ItOokjL ruMDe1SPjqMrgMWAfQFjl/IpHFQKyQlpN7zUJLUvdAathRObAL7YjgvICm0f/Hf8PHhUJXYaxcF+h bfH/DFtpJCdd2A==; In-Reply-To: (message from Aaron Jensen on Fri, 6 Dec 2024 11:28:53 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296529 Archived-At: > From: Aaron Jensen > Date: Fri, 6 Dec 2024 11:28:53 -0500 > Cc: Stefan Monnier , trevor.m.murphy@gmail.com, me@eshelyaron.com, > 73862@debbugs.gnu.org > > Would it be possible, aside from the remapping of the particular face being > built (like header-line-active) to disable remapping when building the > basic faces? It occurred to me that one way to see the problem is that > there is inconsistency in how the remapping are applied (because they are > per-buffer). If it were consistent that the remap was not applied to any > face that the basic face inherited from, then the problem wouldn't appear > to be as bad as it is. It would come across as a limitation, rather than > something that seems like a defect. If we are going to change the C code related to basic faces, I'd prefer the semi-kludgey change I sent a few minutes ago. It at least brings the effect closer to naïve user expectations.