From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sun, 08 Dec 2024 16:57:17 +0200 Message-ID: <86jzcafcj6.fsf@gnu.org> References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3946"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, aaronjensen@gmail.com, 73862@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 15:58:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKIjr-0000qR-Nh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 15:58:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKIjW-00069L-3x; Sun, 08 Dec 2024 09:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKIjT-000699-Kr for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:58:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKIjT-000717-0y for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:58:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=RyX/nnAMeIxVirvlrUpF+Dy0onvTzqSrVo14z6ZgoHU=; b=cvT3Rqb97BGCC8iM3YPMpBL0QbK5K9Cf1nLXxkWcOPtXxuU9lgkJ6PGGgYhtLOIUkjIdypT+GxdSPdG/BDZrVtbgEabrkFXxKTDnimRqDydVM1kx3L8whDhpGlfnWHZhCOqXRhgTUIgOkUnPsNr+Xon83FPW2IbfQa9Lc3bZOV1x2wJirIySHdPwnKOJYYJxCV4EctUKFQTGqyatQZaG/xJb6dKZds/n84SBrlHlZVUi9Op4U+8sL+b/DNGQctttFmMRhc+Pk3KTi0JlshwZY3JUXpzD/bGg/SPcHxCeO6sz5bYN1b+w8VfKKMJrI1Vq/32jO6RNx40WB0Ubvm4sZw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKIjR-0005rE-V7 for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173366986222486 (code B ref 73862); Sun, 08 Dec 2024 14:58:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 8 Dec 2024 14:57:42 +0000 Original-Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKIj7-0005qc-QT for submit@debbugs.gnu.org; Sun, 08 Dec 2024 09:57:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKIj5-0005qL-5R for 73862@debbugs.gnu.org; Sun, 08 Dec 2024 09:57:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKIiy-0006ze-Oe; Sun, 08 Dec 2024 09:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RyX/nnAMeIxVirvlrUpF+Dy0onvTzqSrVo14z6ZgoHU=; b=amGxBipxT8Yk lNwnnjo5oHG6AnqEcNgQS51zEXAe9kTdfoCO6oigJw+8tIciOcDZSc7XBJgzBFw/qWfZah1AY5co1 ArFlIc/pVYwJ5lD11QeXPIttVEkDR/WNO89YTyxXEvu6W35ORwgqMyrEOJzhK7hwM/SSrKvywSfCi w6Tsn1KvsG9/xxguYdx9zFV/Q3lT2BIQNvWK6CkOSMhs3blRKw/s9dbogpVoU3DDGppC451twwHa0 1Ig3j2RI7vQIJiFA8K81vYrClTIXu8iy/DL4BrZA+wm8+w2mxCly2HcOtNwyfEkZCSwaS6kiJToZU 3V3LWYO9ZR5iSpqg/DZb0g==; In-Reply-To: (message from Eshel Yaron on Sun, 08 Dec 2024 15:11:07 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296639 Archived-At: > From: Eshel Yaron > Cc: Aaron Jensen , monnier@iro.umontreal.ca, > trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org > Date: Sun, 08 Dec 2024 15:11:07 +0100 > > Eli Zaretskii writes: > > > We also haven't yet heard from Eshel. > > I don't have any concrete suggestions at this point. It's surely a > complicated situation. Did you try the patch I posted, and if you did, did it resolve your original problems? That's what I wanted to hear, since you were one of the two persons who raised these issues. > The workaround of remapping both header-line-active and > header-line-inactive instead of header-line seems to work. The way I > see it, the essence of the issue is that the "face" abstraction is > leaky, in the sense that some faces (these "basic faces") behave > differently from other faces in some cases that involve inheritance and > remapping. AFAIK, only face-remapping behaves differently, and only when a basic face inherits from another. The inheritance itself work as with other faces. > I think this calls for either changing the way basic faces are > handled so they do behave like any other face, or clearly > documenting their subtleties. Patches to rework the faces support so that these idiosyncrasies are removed will be most welcome. I just don't plan on doing that myself, as I won't have time for that. TIA