unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: 74775@debbugs.gnu.org
Subject: bug#74775: [PATCH] Update browse-url-kde variables
Date: Wed, 11 Dec 2024 14:38:42 +0200	[thread overview]
Message-ID: <86jzc64cod.fsf@gnu.org> (raw)
In-Reply-To: <8734ivrvfr.fsf@> (bug-gnu-emacs@gnu.org)

> Date: Wed, 11 Dec 2024 01:04:56 +0200
> From:  Björn Bidar via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Update browse-url-kde's variables.

Thanks, but when we change the default value of a user option, we need
to update its :version tag (so that commands like customize-changed
could notice that).

> -(defcustom browse-url-kde-program "kfmclient"
> +(defcustom browse-url-kde-program "kde-open"
>    "The name by which to invoke the KDE web browser."

Should we offer the other name as a (non-default) alternative?  It is
still available, right?

>    :type 'string

Should this be 'file instead?

> -(defcustom browse-url-kde-args '("openURL")
> +(defcustom browse-url-kde-args nil
>    "A list of strings defining options for `browse-url-kde-program'."

Should the default value depend on the value of
browse-url-kde-program?  E.g., if that is customized to kfmclient, the
value of this variable should probably not be '("openURL"), right?





       reply	other threads:[~2024-12-11 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8734ivrvfr.fsf@>
2024-12-11 12:38 ` Eli Zaretskii [this message]
2024-12-11 14:03   ` bug#74775: [PATCH] Update browse-url-kde variables Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 14:28     ` Robert Pluim
2024-12-11 16:14     ` Eli Zaretskii
2024-12-11 17:41       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 19:07         ` Eli Zaretskii
2024-12-12 16:44           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-12 18:53             ` Eli Zaretskii
     [not found] <6758c999.050a0220.38af58.bd51SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-11  1:22 ` Stefan Kangas
2024-12-10 23:04 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jzc64cod.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74775@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).