bug#14114: tango-dark: background highlighting not working properly

bug#14114: tango-dark: background highlighting not working properly

[James Jong]

[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]

The following code does not work well on the builtin `tango-dark` theme:

    (custom-set-faces
     '(region ((t (:inherit nil :background "RoyalBlue4"))))
     '(highlight ((t (:inherit region :background "dark olive green"))))
     '(hl-line ((t (:inherit highlight)))))

Region highlighting works well and respects foreground faces:

[image: Inline image 1]

but line highlighting doesn't:

[image: Inline image 2]

There is a thread on StackOverflow discussing this:
http://stackoverflow.com/questions/15733873/customizing-highlighting-faces-in-emacs-only-change-the-background-color

Any thoughts?
Thanks,

James

[-- Attachment #1.2: Type: text/html, Size: 1269 bytes --]

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 9825 bytes --]

[-- Attachment #3: image.png --]
[-- Type: image/png, Size: 14037 bytes --]

bug#14114: tango-dark: background highlighting not working properly

[Nicolas Petton]

tags 14114 notabug
close 14114
stop

James Jong <ribonucleico@gmail.com> writes:

> The following code does not work well on the builtin `tango-dark` theme:
>
>     (custom-set-faces
>      '(region ((t (:inherit nil :background "RoyalBlue4"))))
>      '(highlight ((t (:inherit region :background "dark olive green"))))
>      '(hl-line ((t (:inherit highlight)))))
>
> Region highlighting works well and respects foreground faces:

That's the region face, not the highlight face (for which tango-dark
sets a foreground color).

> Inline image 1
>
> but line highlighting doesn't:
>
> Inline image 2

I think that's to be expected, since the tango-dark theme sets a
foreground color for the highlight face:

   `(highlight ((,class (:foreground ,alum-6 :background ,butter-2))))

So I'm closing this ticket.

Cheers,
Nico