From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 17:33:01 +0000 Message-ID: <86im6o55f6.fsf@gmail.com> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83im6o2n67.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25185"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: 43725@debbugs.gnu.org Cancel-Lock: sha1:Q5pnw1cLfMJWxcYlxeWXd3bWW64= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 18:34:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD9fP-0006QI-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 18:34:11 +0100 Original-Received: from localhost ([::1]:57428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD9fO-0007mW-4E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 12:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9fG-0007mM-BV for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 12:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD9fG-0003vs-2H for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 12:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD9fF-0001Qi-TK for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 12:34:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16137559945440 (code B ref -1); Fri, 19 Feb 2021 17:34:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Feb 2021 17:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:50309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD9eT-0001Pg-Oz for submit@debbugs.gnu.org; Fri, 19 Feb 2021 12:33:14 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD9eR-0001PY-EN for submit@debbugs.gnu.org; Fri, 19 Feb 2021 12:33:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9eR-0007hZ-6S for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 12:33:11 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:42946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9eO-0003hL-NX for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 12:33:10 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lD9eM-0005CD-Dy for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 18:33:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200367 Archived-At: On Fri 19 Feb 2021, Pip Cet wrote: > On Fri, Feb 19, 2021 at 2:35 PM Andrea Corallo wrote: >> > On Fri, Feb 19, 2021 at 2:16 PM Andrea Corallo wrote: >> >> >> > comp.c:1174:22: warning: logical ¡®or¡¯ of collectively exhaustive tests is always true [-Wlogical-op] >> >> >> > 1174 | if (val > LONG_MAX || val < LONG_MIN) >> >> >> > | ^~ >> >> >> > >> >> >> > Not sure what's the best way to silence it or if we want to revert to >> >> >> > the previous formulation. >> >> >> >> >> >> Maybe it's me, but I had a hard time parsing that warning. IIUC, the >> >> >> tests are both trivially false? And oring two trivially false >> >> >> conditions shouldn't trigger a warning, should it? >> >> > >> >> > No, I think it tries to say that val is always either greater than >> >> > LONG_MAX or smaller than LONG_MIN. >> >> >> >> Exactly, the warning is about the fact that all the other conditions >> >> will never be evaluated. The phrasing is admittedly quite cryptic tho. >> > >> > I thought you said this was a setup where the argument _does_ fit a long? >> >> There we are dispatching if 'val' can be expressed or not with a long. >> >> 'val' is an EMACS_INT so depending on the configuration it might fit in >> a long by definition, when this happen GCC sees the first condition in >> or as always true etc etc... :) > > So val is greater than LONG_MAX? How can this happen? A 32bit emacs configured with "--with-wide-int" where EMACS_INT is wider than long. AndyM