From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Tue, 28 Dec 2021 20:37:52 +0200 Organization: LINKOV.NET Message-ID: <86ilv8pnf3.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11688"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 20:04:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2Hld-0002oY-Es for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 20:04:13 +0100 Original-Received: from localhost ([::1]:53794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2Hlc-0001Qh-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 14:04:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2HlS-0001Kx-Sg for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2HlS-0007B1-Io for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2HlS-0008BJ-FT for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164071821431408 (code B ref 51809); Tue, 28 Dec 2021 19:04:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 28 Dec 2021 19:03:34 +0000 Original-Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Hl0-0008AW-1P for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:03:34 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:60669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Hku-0008A2-A2 for 51809@debbugs.gnu.org; Tue, 28 Dec 2021 14:03:28 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 26AE8240008; Tue, 28 Dec 2021 19:03:20 +0000 (UTC) In-Reply-To: <87wnjrkrwd.fsf@gmail.com> (Matthias Meulien's message of "Sun, 26 Dec 2021 21:55:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223271 Archived-At: >> I am now back to the origin of this bug report (toggling visibility of >> some diff hunks depending on long lines, chunks size, or file names) and >> I see there's a major drawback with the outline mode default visibility >> state approach: When outline minor mode is set through diff-mode-hook, >> the buffer is emtpy and applying the default state visibility is a >> no-op; It's a side-effect of the buffer content being generated >> asynchronously... > > I fixed it using an advice to `vc-diff-finish', but wondering whether > there's a clean way to achieve the same... > [...] > (defadvice vc-diff-finish (after ensure-outline-apply-default-state activate) > (when outline-minor-mode > (outline-apply-default-state))) After bug#52855 will be closed, it should be possible to do this by: (add-hook 'vc-diff-finish-functions 'outline-apply-default-state) Also xref works nicely, although I don't know why it requires `outline-apply-default-state' after enabling `outline-minor-mode': #+begin_src emacs-lisp (add-hook 'xref-after-update-hook (lambda () (setq-local outline-regexp (if (eq xref-file-name-display 'abs) "/" "[^ 0-9]") outline-default-state 1 outline-default-state-subtree-visibility '((match-regexp . "ChangeLog\\|test/manual/etags"))) (outline-minor-mode +1) (outline-apply-default-state))) #+end_src