From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Date: Thu, 10 Feb 2022 20:58:13 +0200 Organization: LINKOV.NET Message-ID: <86iltmpn0a.fsf@mail.linkov.net> References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18241"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Ergus , 53910@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 10 20:00:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIEfx-0004cd-Ea for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Feb 2022 20:00:17 +0100 Original-Received: from localhost ([::1]:50952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIEfv-0005Rk-TY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Feb 2022 14:00:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIEfi-0005Ox-Lg for bug-gnu-emacs@gnu.org; Thu, 10 Feb 2022 14:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIEfi-00059k-8J for bug-gnu-emacs@gnu.org; Thu, 10 Feb 2022 14:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIEfh-0006OX-VN for bug-gnu-emacs@gnu.org; Thu, 10 Feb 2022 14:00:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Feb 2022 19:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53910-submit@debbugs.gnu.org id=B53910.164451954224454 (code B ref 53910); Thu, 10 Feb 2022 19:00:01 +0000 Original-Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 18:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:57142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIEej-0006MI-Tl for submit@debbugs.gnu.org; Thu, 10 Feb 2022 13:59:02 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIEeh-0006Lv-Og; Thu, 10 Feb 2022 13:59:00 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3B04040007; Thu, 10 Feb 2022 18:58:51 +0000 (UTC) In-Reply-To: <87o83f7y3x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 10 Feb 2022 12:35:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226622 Archived-At: close 53910 29.0.50 thanks >> This is because of this line recently added to context-menu-map: >> >> (select-window (posn-window (event-start click))) >> >> that switches buffers. >> >> But the question remains: does describe-map really need to build >> the complete context menu or should it ignore its :filter keyword? > > Hm... I don't know, but I don't think a call to `lookup-key' should > result in a different buffer being selected in any case. It was surprising that select-window invoked on the same selected window switches the buffer to the originally displayed window-buffer. Maybe Martin could explain this. Anyway, this is fixed now by not calling select-window on the already selected window.