From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#59149: Feature Request: Report progress of long requests in Eglot Date: Wed, 23 Nov 2022 10:01:28 -0800 Message-ID: <86ilj5k0sn.fsf@stephe-leake.org> References: <87educqkar.fsf@dfreeman.email> <86cz9jmg9r.fsf@stephe-leake.org> <87k03qvmla.fsf@dfreeman.email> <86fseckwvb.fsf@stephe-leake.org> <87tu2pohub.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59149@debbugs.gnu.org To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 19:03:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxu5M-00084e-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 19:03:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxu4m-0002mN-CE; Wed, 23 Nov 2022 13:02:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxu4Q-0002jf-W1 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:02:18 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxu4Q-0000MV-JY for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxu4Q-00012c-Eu for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: 59149@debbugs.gnu.org, bug-gnu-emacs@gnu.org Original-Received: via spool by 59149-submit@debbugs.gnu.org id=B59149.16692265203986 (code B ref 59149); Wed, 23 Nov 2022 18:02:02 +0000 Original-Received: (at 59149) by debbugs.gnu.org; 23 Nov 2022 18:02:00 +0000 Original-Received: from localhost ([127.0.0.1]:56133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxu4N-00012E-IP for submit@debbugs.gnu.org; Wed, 23 Nov 2022 13:01:59 -0500 Original-Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:36335 helo=progateway7-pub.mail.pro1.eigbox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxu4E-00011h-VJ for 59149@debbugs.gnu.org; Wed, 23 Nov 2022 13:01:52 -0500 Original-Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 3F82510044358 for <59149@debbugs.gnu.org>; Wed, 23 Nov 2022 18:01:31 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id xu3uowAdLdidSxu3vo2Zh8; Wed, 23 Nov 2022 18:01:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=cckXElPM c=1 sm=1 tr=0 ts=637e5ffb a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=9i_RQKNPAAAA:8 a=4kIBHYGHjJJhGVP9-v4A:9 a=hqnlY9SSy_kA:10:uccc_2email_address a=Ev4oQ7kfJBNsvnoXShoW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wm+5/MaqEqwN5n2d5V48pAQAPB8GYcWxkX39kwZx2DA=; b=IynkogwCgCzS8Atc9Gu+7ufEMg 9zk8k5jFhNvtptgxlK4p8YwQErE+D1LyuGxnRWotDkOnpY0qh5LDtpMwA/iQ/r00wbQGbxDH9N1hR HK4iON0ObEIXXf7ay70ao382/vwyb/dAsQNWHFwfFtBl5BiVroQWAWCZuklj7HkS+bsUKeYk++7yG lVVZlB3+Y4D6WytjMQYis0pW0YF2td2didHyAwe1fFJyE9zqO8DBR2hKt8ogOTzbACwt+PoEo0ReF DsFZIYtH3Os+/Unykmr2+0gF8FBGgh7k/MaI1jvFFvtYb+sVAI8LcTrhbRyksMhT+UpQUNCg2wJX3 OjbuiudA==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:64038 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oxu3u-001uxC-IL; Wed, 23 Nov 2022 11:01:30 -0700 In-Reply-To: <87tu2pohub.fsf@dfreeman.email> (Danny Freeman's message of "Wed, 23 Nov 2022 09:12:12 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oxu3u-001uxC-IL X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:64038 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248762 Archived-At: Danny Freeman writes: > Stephen Leake writes: > >> I just ran into the progress reporter in eglot--apply-text-edits; I'd >> like to turn that off, but leave other progress-reporters on. >> >> So we need something more fine-grained: >> >> (setq eglot-progress-reporter-disable '(apply-text-edits)) > > I believe that is a different progress reporter, unrelated to the one I > would like to introduce. It is not a progress report that come from the > lsp server, so I don't think it would be good to conflate them. True, but how is the user to know where it comes from? We could provide something like: eglot-server-progress-reporter-disable eglot-client-progress-reporter-disable How does the user know which to set? They'll just set both, so there might as well be only one. > If the user wants to ignore specific progress indicators from the lsp > servers then they could implement an empty version of > eglot-handle-notification that matches their progress token. I guess that's a reasonable starting point, but it doesn't work for apply-text-edits. > The result of this patch is a series of messages that display in the > minibuffer: > > ``` > [eglot:website] clojure-lsp: > [eglot:website] clojure-lsp: 5% Finding kondo config ... And the user can still use the minibuffer for find-file etc; the messages are displayed to the right. Which can be confusing at first, but works nicely. -- -- Stephe