From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Sun, 29 Jan 2023 19:55:00 +0200 Organization: LINKOV.NET Message-ID: <86ilgpb3lv.fsf@mail.linkov.net> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> <83r0vkgj7l.fsf@gnu.org> <87h6wawo2k.fsf@gmail.com> <831qnea5ye.fsf@gnu.org> <87357t2xyh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 60841@debbugs.gnu.org, gregory@heytings.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 19:33:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMCUW-0003eK-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 19:33:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMCUG-0003NN-3I; Sun, 29 Jan 2023 13:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCUB-0003BU-8N for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:33:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMCUA-00077i-TS for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:33:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMCUA-0006qJ-GB for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.167501717426285 (code B ref 60841); Sun, 29 Jan 2023 18:33:02 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 29 Jan 2023 18:32:54 +0000 Original-Received: from localhost ([127.0.0.1]:45372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCU2-0006pt-1C for submit@debbugs.gnu.org; Sun, 29 Jan 2023 13:32:54 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:51615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCU0-0006pa-Di for 60841@debbugs.gnu.org; Sun, 29 Jan 2023 13:32:52 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 09841240004; Sun, 29 Jan 2023 18:32:41 +0000 (UTC) In-Reply-To: <87357t2xyh.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Sun, 29 Jan 2023 15:54:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254374 Archived-At: >>> * :stipple nil: foot blown with or without the patch 🤷 >>> * :inherit 'default: foot blown with or without the patch 🤷 >>> >>> Problem with :stipple nil and :inherit 'default explained in [1]. >>> indicate-copied-region will become affected if the current patch goes >>> in. >> >> I wouldn't be bothered by :stipple whose value is nil. Why would >> someone do such a thing, except when the face is meant to be merged >> with other faces (which are expected to have non-nil :stipple >> attributes)? > > The only place where this "matters" is in replace.el, AFAICT: > > 1. Customize list-matching-lines-prefix-face to 'default, > > 2. (face-differs-from-default-p list-matching-lines-prefix-face) > ↦ :stipple I still don't understand why (face-differs-from-default-p 'default) should return :stipple even in a clean state after emacs -Q. This means that the default face always differs from itself? Isn't it natural to expect that this relation should be reflexive? > 3. Luckily this does not impact replace-el:occur-1, since this check… > > (if (face-differs-from-default-p list-matching-lines-prefix-face) > list-matching-lines-prefix-face) > > … is redundant AFAIU: the goal is to _not_ apply > list-matching-lines-prefix-face if it is close to 'default, and > instead… leave the default face? So why bother checking? > > CC'ing Juri, who installed this check in bug#14017, for comment in case > I missed something. Sorry, I don't remember the reason for this check. But looking now it seems it's just optimization to not run the code that puts unnecessary font-lock-face properties. > (Hi Juri 👋 For context, the current report is about refining > indicate-copied-region to avoid spuriously considering the region as > "unhighlighted" and triggering the point-mark swap; see attached > patches. I believe this aspect of the report might also be of interest > to you, given your participation in bug#42865) Thanks, I like your patch that adds copy-region-blink-predicate.