From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#68377: Cannot commit parts of *vc-diff* on Microsoft Windows
Date: Sat, 10 Feb 2024 10:06:45 +0200
Message-ID: <86il2wvj3e.fsf@gnu.org>
References: <87le8wy65p.fsf@gnu.org> <83r0iokq9q.fsf@gnu.org>
 <65db305f-0606-445b-b034-fc069800a244@gutov.dev> <83jzogkjv5.fsf@gnu.org>
 <7b1d2533-b214-4646-9145-5de678759009@gutov.dev> <83ttnfeuim.fsf@gnu.org>
 <86y1cb87k3.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="22642"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 68377-done@debbugs.gnu.org, dmitry@gutov.dev
To: sds@gnu.org
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 09:08:15 2024
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1rYiPG-0005cQ-7x
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 09:08:14 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1rYiOu-0006Qa-2u; Sat, 10 Feb 2024 03:07:52 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rYiOp-0006Pu-GZ
 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 03:07:47 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rYiOp-0003Yg-7t
 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 03:07:47 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rYiP4-00031L-Gn
 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 03:08:02 -0500
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 10 Feb 2024 08:08:02 +0000
Resent-Message-ID: <handler.68377.D68377.170755243411472.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 68377
X-GNU-PR-Package: emacs
Mail-Followup-To: 68377@debbugs.gnu.org, eliz@gnu.org, sds@gnu.org
Original-Received: via spool by 68377-done@debbugs.gnu.org id=D68377.170755243411472
 (code D ref 68377); Sat, 10 Feb 2024 08:08:02 +0000
Original-Received: (at 68377-done) by debbugs.gnu.org; 10 Feb 2024 08:07:14 +0000
Original-Received: from localhost ([127.0.0.1]:50940 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1rYiOG-0002yw-Rw
 for submit@debbugs.gnu.org; Sat, 10 Feb 2024 03:07:13 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56842)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@gnu.org>) id 1rYiOE-0002yQ-6L
 for 68377-done@debbugs.gnu.org; Sat, 10 Feb 2024 03:07:11 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rYiNt-0003Uf-7W; Sat, 10 Feb 2024 03:06:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=TrOVdojNzGMVWNaDtSoKqoS2b1PY5wGIcDkcFNjcxyw=; b=ZjJStOh0BmBJ
 KQHmbKAquxXP4zrGuOe7fhZAevB0hNMa6S5UN8DprS3sLVfbD4HIelJVKSBCTAbS8uKcahLYRyZN/
 rUpYy7gz9uxIeylCXn4KANcvEyg0cGRvMFRBBYHVCQJl1r37oIrb9sr4TRiaBxQHNcDr7+zISSy2X
 ZLf5/BWGZ6+31VUK4hLMYDxEM/IUUzvRfshZEBTeMCIVqgpJfa/KI3vyiZ7CYYg76pdMZVHS9ndIG
 7HEoLuo+z1kPM/bzttuYDq4UXhiC1NYBDCl1dW+GlPyh5rOO/EBpa6YUrlly6CRSj7U2wQweuKF63
 Dk4dkh4W8EJL1b06weK29A==;
In-Reply-To: <86y1cb87k3.fsf@gnu.org> (message from Eli Zaretskii on Sat, 27
 Jan 2024 11:11:24 +0200)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:279723
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/279723>

> Cc: 68377@debbugs.gnu.org, dmitry@gutov.dev
> Date: Sat, 27 Jan 2024 11:11:24 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping!  Sam, would you please try this on the master branch?
> 
> > Cc: 68377@debbugs.gnu.org, sds@gnu.org
> > Date: Sun, 14 Jan 2024 18:42:41 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > Date: Thu, 11 Jan 2024 17:07:48 +0200
> > > From: Dmitry Gutov <dmitry@gutov.dev>
> > > Cc: 68377@debbugs.gnu.org, sds@gnu.org
> > > 
> > > On 11/01/2024 16:47, Eli Zaretskii wrote:
> > > >> Date: Thu, 11 Jan 2024 15:19:26 +0200
> > > >> Cc:68377@debbugs.gnu.org
> > > >> From: Dmitry Gutov<dmitry@gutov.dev>
> > > >>
> > > >> On 11/01/2024 14:28, Eli Zaretskii wrote:
> > > >>>> From: Sam Steingold<sds@gnu.org>
> > > >>>> Date: Wed, 10 Jan 2024 21:07:14 -0500
> > > >>>>
> > > >>>> https://emacs.stackexchange.com/q/80039/795
> > > >>>>
> > > >>>> Emacs has a beautiful feature: in the `*vc-diff*` buffer (generated by [`vc-diff`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Old-Revisions.html) either by <kbd>C-x v =</kbd> in a file buffer or by <kbd>=</kbd> in a `*vc-dir*` buffer), kill unwanted hunks with <kbd>k</kbd> (i.e., [`diff-hunk-kill`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Diff-Mode.html)) and then commit the remaining hunks with <kbd>C-x v v</kbd> (i.e., [`vc-next-action`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Basic-VC-Editing.html)). If you don't know about it -- try it, it is incredibly useful!
> > > >>> (I must say that formatting of this report is AWFUL!  How can a human
> > > >>> being be expected to read and understand it it??  PLEASE try to make
> > > >>> bug reports more readable in the future.)
> > > >> Looked fine to me.
> > > >>
> > > >> I think the Markdown format is very readable.
> > > > It isn't Markdown that bothered me, it's some kind of HTML mixed in,
> > > > but in an email message whose format is plain text (at least as I got
> > > > it here).
> > > 
> > > The <kbd> tags? These are also supported by Markdown. The links too.
> > > 
> > > >> I think this is the same as bug#65049, meaning that it's fixed on
> > > >> master, but not in Emacs 29.1 (which was the version specified in the
> > > >> report).
> > > > Possibly.  If Sam says it works for him on master, we will know.
> > > 
> > > Yes, let's see what he says.
> > 
> > Sam, could you please chime in after testing this in Emacs 30?
> > 
> > Thanks.

No further comments within a month, so I presume the bug is indeed
fixed on master, and I'm therefore closing it.