From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69983: Use category for display-buffer-alist Date: Wed, 10 Apr 2024 09:45:49 +0300 Organization: LINKOV.NET Message-ID: <86il0pd8da.fsf@mail.linkov.net> References: <86h6gv7e0z.fsf@mail.linkov.net> <3e7b8e64-0a5f-4888-a443-9c69a5fffd98@gmx.at> <86wmpdu0fa.fsf@mail.linkov.net> <86h6gf69jd.fsf@mail.linkov.net> <86sezyjpsn.fsf@mail.linkov.net> <86a5m3jboy.fsf@mail.linkov.net> <86v84rvwpa.fsf@gnu.org> <867ch7gfa4.fsf@mail.linkov.net> <86bk6iwftq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27192"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: rudalics@gmx.at, 69983@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 10 08:54:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruRqp-0006x5-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Apr 2024 08:54:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruRqK-0007Cu-Qv; Wed, 10 Apr 2024 02:54:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruRqF-0007CN-Ay for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 02:53:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruRqE-0007Br-Oq for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 02:53:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruRqM-0003iP-PK for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Apr 2024 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69983 X-GNU-PR-Package: emacs Original-Received: via spool by 69983-submit@debbugs.gnu.org id=B69983.171273201814105 (code B ref 69983); Wed, 10 Apr 2024 06:54:02 +0000 Original-Received: (at 69983) by debbugs.gnu.org; 10 Apr 2024 06:53:38 +0000 Original-Received: from localhost ([127.0.0.1]:51935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruRpx-0003fR-T0 for submit@debbugs.gnu.org; Wed, 10 Apr 2024 02:53:38 -0400 Original-Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:38385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruRpg-0003bO-0T for 69983@debbugs.gnu.org; Wed, 10 Apr 2024 02:53:25 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CFFC31C0003; Wed, 10 Apr 2024 06:53:03 +0000 (UTC) In-Reply-To: <86bk6iwftq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Apr 2024 21:28:49 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283027 Archived-At: >> >> >>> One problem is that I can't find an alist item to limit >> >> >>> the window height, i.e. can't find window-max-height >> >> >>> that would be like window-min-height, but to set a max height. >> >> >>> Could you suggest such an alist item? >> >> >> >> >> >> The intention was to have such behavior: >> >> >> 1. after the first call that adds 1 line to the output buffer, >> >> >> resize the displayed buffer to 1 line height; >> >> >> 2. after the second call grow the output window height to 2 lines, >> >> >> it seems fit-window-to-buffer should do this; >> >> >> 3. after 10th call limit the window height to 10 lines only, >> >> >> so later calls should not increase the output window height >> >> >> more than 10 lines. >> >> > >> >> > You mean that when a 'window-height' action alist entry is provided that >> >> > specifies 'fit-window-to-buffer' as 'window-height' value, we should >> >> > pass it the value of any 'window-max-height' entry present as MAX-HEIGHT >> >> > argument here >> >> > >> >> > ((functionp height) >> >> > (ignore-errors (funcall height window)) >> >> > >> >> > and probably do the same for all the other arguments of >> >> > 'fit-window-to-buffer'? >> >> >> >> Probably we can't change the existing arguments to not break >> >> backward-compatibility. But this is fine since still can use >> >> the explicit function call: >> >> >> >> diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el >> >> index 8b43c6a8726..75b519067ac 100644 >> >> --- a/lisp/emacs-lisp/warnings.el >> >> +++ b/lisp/emacs-lisp/warnings.el >> >> @@ -362,7 +362,12 @@ display-warning >> > >> > Why does adding a new feature require changes in existing features, >> > let alone such basic features as warnings.el? Can't we introduce the >> > category and leave warnings.el, flymake.el, and others alone? I don't >> > want to make unsolicited changes in those other places, because that >> > runs the risk of disturbing people's arrangements of windows and their >> > habits as to where the various windows pop up. >> >> This is part of continuing development to improve >> window handling for users of horizontally split windows. > > I don't think I understand how category is related to horizontally > split windows, please explain. We are still in the context of > bug#69983 and its Subject, aren't we? > > If there are some problems related to horizontally split windows that > interfere with showing warnings, please describe them. The function 'display-warning' has the argument 'buffer-name'. This means it's impossible to match the buffer name in 'display-buffer-alist', because the buffer name can be anything. Therefore the 'category' should be added to the 'display-buffer' call in 'display-warning'. Currently the warning buffer is displayed in a random place in horizontally split windows. The change is needed to display it in the consistent place. This change is accompanied with adding the category for the case if someone don't like this change (very unlikely) and wants to revert it to display the buffer in a random place. It will be possible to customize this by using the category in 'display-buffer-alist'.