From: Eli Zaretskii <eliz@gnu.org>
To: Lin Sun <sunlin7.mail@gmail.com>, kobarity <kobarity@gmail.com>
Cc: 70815@debbugs.gnu.org
Subject: bug#70815: [PATCH] ; Enahnce python-tests.el to adapt different python interpreters
Date: Sat, 11 May 2024 12:05:15 +0300 [thread overview]
Message-ID: <86ikzk3eic.fsf@gnu.org> (raw)
In-Reply-To: <CABCREdpJhB03tGiR6V1FYxOai0Zswnr3mAMOEPzJLDccWthTTA@mail.gmail.com> (message from Lin Sun on Tue, 7 May 2024 06:53:05 +0000)
> From: Lin Sun <sunlin7.mail@gmail.com>
> Date: Tue, 7 May 2024 06:53:05 +0000
>
> The python-tests.el will fail on finding interpreter "python" for
> there is no "python" on CentOS8, Ubuntu 20.04, only "python3" exists
> after installation.
Thanks, I have some comments, and maybe kobarity will have as well.
> +(defun python-tests-get-shell-interpreter (&optional refresh)
AFAICT, this function is never called with the optional REFRESH
argument non-nil, so why do we need it?
> + (if (and python-tests-shell-interpreter (null refresh))
> + python-tests-shell-interpreter
> + (setq python-tests-shell-interpreter
> + (or (when-let* ((interpreter (getenv "EMACS_PYTHON_INTERPRETER")))
> + (or (executable-find interpreter)
> + (error "Not found EMACS_PYTHON_INTERPRETER: %s" interpreter)))
Is it indeed useful to error out here? Should we instead fall back to
the default list, '("python" "python3" "python2") ?
> + (cl-some #'executable-find '("python" "python3" "python2"))))))
cl-some is in cl-extra, so the test should require it.
next prev parent reply other threads:[~2024-05-11 9:05 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 6:53 bug#70815: [PATCH] ; Enahnce python-tests.el to adapt different python interpreters Lin Sun
2024-05-11 9:05 ` Eli Zaretskii [this message]
2024-05-11 13:37 ` kobarity
2024-05-11 14:27 ` Lin Sun
2024-05-12 2:06 ` kobarity
2024-05-18 22:20 ` Stefan Kangas
2024-05-19 5:54 ` Eli Zaretskii
2024-05-20 0:08 ` Lin Sun
2024-05-20 15:52 ` kobarity
2024-05-20 17:51 ` Lin Sun
2024-05-21 14:04 ` kobarity
2024-05-21 15:34 ` Lin Sun
2024-05-22 14:38 ` kobarity
2024-05-23 13:09 ` Eli Zaretskii
2024-05-26 10:52 ` Mattias Engdegård
2024-05-26 12:05 ` kobarity
2024-05-26 12:21 ` Mattias Engdegård
2024-05-26 12:36 ` kobarity
2024-05-26 13:23 ` Mattias Engdegård
2024-05-26 14:15 ` kobarity
2024-05-26 15:00 ` kobarity
2024-05-26 15:24 ` Mattias Engdegård
2024-05-27 12:33 ` kobarity
2024-05-27 12:45 ` Eli Zaretskii
2024-05-28 12:30 ` Mattias Engdegård
2024-05-28 15:17 ` kobarity
2024-05-28 16:09 ` Mattias Engdegård
2024-05-29 14:56 ` kobarity
2024-05-30 10:09 ` Mattias Engdegård
2024-06-02 13:20 ` kobarity
2024-06-03 14:02 ` Mattias Engdegård
2024-06-03 14:34 ` kobarity
2024-06-03 16:24 ` kobarity
2024-06-04 14:29 ` kobarity
2024-06-05 10:25 ` Mattias Engdegård
2024-06-05 11:52 ` kobarity
2024-06-08 15:34 ` kobarity
2024-06-09 13:58 ` Mattias Engdegård
2024-06-10 14:57 ` kobarity
2024-06-10 15:44 ` Mattias Engdegård
2024-05-26 15:56 ` Eli Zaretskii
2024-05-26 23:06 ` Stefan Kangas
2024-05-27 11:18 ` Eli Zaretskii
2024-05-27 12:20 ` Mattias Engdegård
2024-05-27 12:43 ` Eli Zaretskii
2024-05-26 15:52 ` Eli Zaretskii
2024-05-27 10:24 ` Mattias Engdegård
2024-05-27 11:19 ` Lin Sun
2024-05-26 15:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ikzk3eic.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70815@debbugs.gnu.org \
--cc=kobarity@gmail.com \
--cc=sunlin7.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).