From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71355: 30.0.50; [PATCH] Improve performance of buffered output in Eshell Date: Wed, 05 Jun 2024 15:06:21 +0300 Message-ID: <86ikynk30i.fsf@gnu.org> References: <22b0dc8f-11dc-5fd2-c75d-88c17580d28d@gmail.com> <848772e9-5ef0-8a8a-decd-c0b79366ec27@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71355@debbugs.gnu.org, stefankangas@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 14:25:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEphd-0009yu-Lb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 14:25:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEphD-0001Fs-6Z; Wed, 05 Jun 2024 08:24:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEphB-0001En-BW for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:24:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEphB-0001xv-2c for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:24:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEphO-0003Vr-Kw for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71355-submit@debbugs.gnu.org id=B71355.171759026913389 (code B ref 71355); Wed, 05 Jun 2024 12:25:02 +0000 Original-Received: (at 71355) by debbugs.gnu.org; 5 Jun 2024 12:24:29 +0000 Original-Received: from localhost ([127.0.0.1]:57506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpgr-0003Ts-7t for submit@debbugs.gnu.org; Wed, 05 Jun 2024 08:24:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpgo-0003TO-93 for 71355@debbugs.gnu.org; Wed, 05 Jun 2024 08:24:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEpPZ-0005pM-JD; Wed, 05 Jun 2024 08:06:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nSGCJ+bK4bGPI1EOay7U/RluxR4Iv6RRjBpugnPWlbs=; b=NFxjpntRQwm6 TZjBGVU5dIA2vJB2TESnOSFxD4w+u+d/SXjxfZ7uZahHv7+OTDEpBTQ5JZJgKf9IZ/nACU0/CIYmM LzXRZ9Cy+dzkfxSB6cMLO6UNu05YV2CGvnK0S+uEmwm1QOKx6q3eH8G3lPiqoNfhwcAZvECsnMS3+ O0bGJnL4FyVQhxpzBJkw8Allw0vbEYNW/lOuRIkeqmU6g3hKwUYO35wjwzpVEGvCwQ+CwssaaKbS4 zWPBljPb7yL3HD76/cTeAZrMmbXOYHgP8xRYW0Z2nq40DowzyK46zOV/2X7gxJ8XpZI4CAp4qehqt /PPd9FN3R2SCr4zLdIs7EQ==; In-Reply-To: <848772e9-5ef0-8a8a-decd-c0b79366ec27@gmail.com> (message from Jim Porter on Tue, 4 Jun 2024 20:50:52 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286597 Archived-At: > Date: Tue, 4 Jun 2024 20:50:52 -0700 > From: Jim Porter > > On 6/4/2024 6:55 PM, Jim Porter wrote: > > On 6/4/2024 2:52 PM, Stefan Kangas wrote: > >> Could the docstring be expanded to explain what a user can expect to > >> happen if they increase or decrease this value? > > > > Sure, that makes sense. Essentially, smaller values will be slower, but > > may update faster (subject to the redisplay throttling), whereas larger > > values are the opposite. > > I've expanded this docstring and a few others, plus added a simple test > to make sure Eshell's built-in "cat" still works. Is 2K indeed the optimal size? It is about 25 80-column lines, which is quite a lot. "Normal" shells send output to the screen in smaller chunks. How about 128 instead? or maybe some small multiple of the line length, like 1 or 2?