From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71724: 30.0.50; [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region' Date: Sun, 23 Jun 2024 08:06:10 +0300 Message-ID: <86iky0fdtp.fsf@gnu.org> References: <2215304.Hq7AAxBmiT@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13755"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71724-done@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 07:07:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLFRj-0003M9-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 07:07:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLFRS-00006h-9L; Sun, 23 Jun 2024 01:07:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLFRO-00005z-Bp for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 01:07:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLFRO-0002pm-3g for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 01:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLFRN-0005eh-Vk for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 01:07:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 05:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 71724@debbugs.gnu.org, eliz@gnu.org, v.pupillo@gmail.com Original-Received: via spool by 71724-done@debbugs.gnu.org id=D71724.171911918021612 (code D ref 71724); Sun, 23 Jun 2024 05:07:01 +0000 Original-Received: (at 71724-done) by debbugs.gnu.org; 23 Jun 2024 05:06:20 +0000 Original-Received: from localhost ([127.0.0.1]:44508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLFQi-0005cW-Ab for submit@debbugs.gnu.org; Sun, 23 Jun 2024 01:06:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLFQg-0005cB-B2 for 71724-done@debbugs.gnu.org; Sun, 23 Jun 2024 01:06:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLFQa-0002d2-Gi; Sun, 23 Jun 2024 01:06:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tn0q7MLmb3thqE6JowjxUubI/h7chsuiDwT4MLYngQc=; b=QP9XZc7pkNQk rjxduJ7bxBvQiWhnVhxJ/63wiTn0tQjhbuwPWunam97ZTSFI027ic7rfz4yDc+EH/uWxjTwiogF4W dRj7Reg1SA4ea3jb14tOPYfBYZYy+H6DID3n7Jr2eUbSWYJmo9OfOGtDiVoDwoTbVrFldtOluaI3g 1OAm20Jp0FRTzP1Ma6hZfHYqCVkyIKPCT/bGG7DG0cXC+X5m5gucVW6tPa/fPUdtZTD2Fwta9BLTB rj1KncKodDc8alZ9H8b04YC1IFt8YqJCDEv00ysCGCO15Xbo7pR0eoEsVWwKkOS/mCHwI9VwQLJxJ JhqxTt1Z/M61Apj6tAFHHQ==; In-Reply-To: <2215304.Hq7AAxBmiT@fedora> (message from Vincenzo Pupillo on Sat, 22 Jun 2024 23:36:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287758 Archived-At: > From: Vincenzo Pupillo > Date: Sat, 22 Jun 2024 23:36:13 +0200 > > this patch adds a new feature to colorize a property when it's value is a text > that represents a CSS color. It will be fontified such that its background is > the color itself, like in 'cs-ts-mode'. > A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle this > behavior. Thanks, installed, and closing the bug. Please in the future observe our conventions for the commit log messages: > Subject: [PATCH] Colorize CSS property value like `css--fontify-region' > > If the value of a property is text representing a CSS color, it will be > fontified such that its background is the color itself. > 'php-ts-mode-css-fontify-colors' can be used to disable this behaviour. These lines are too long. They will be indented by a TAB in the generated ChangeLog file, so they should preferably be no longer than 65 characters. > * lisp/progmodes/php-ts-mode.el (php-ts-mode-css-fontify-colors): > New custom var. ^^^ Please don't leave this whitespace at the beginning of lines. > * lisp/progmodes/php-ts-mode.el (php-ts-mode): Use the new function. This line is also too long. I usually correct any log messages that need it, but if you observe these conventions better, it will make my job easier. Thanks.