unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vincenzo Pupillo <v.pupillo@gmail.com>
Cc: 71724-done@debbugs.gnu.org
Subject: bug#71724: 30.0.50; [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region'
Date: Sun, 23 Jun 2024 08:06:10 +0300	[thread overview]
Message-ID: <86iky0fdtp.fsf@gnu.org> (raw)
In-Reply-To: <2215304.Hq7AAxBmiT@fedora> (message from Vincenzo Pupillo on Sat, 22 Jun 2024 23:36:13 +0200)

> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Date: Sat, 22 Jun 2024 23:36:13 +0200
> 
> this patch adds a new feature to colorize a property when it's value is a text 
> that represents a CSS color. It will be fontified such that its background is 
> the color itself, like in 'cs-ts-mode'.
> A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle this 
> behavior.

Thanks, installed, and closing the bug.

Please in the future observe our conventions for the commit log
messages:

> Subject: [PATCH] Colorize CSS property value like `css--fontify-region'
> 
> If the value of a property is text representing a CSS color, it will be
> fontified such that its background is the color itself.
> 'php-ts-mode-css-fontify-colors' can be used to disable this behaviour.

These lines are too long.  They will be indented by a TAB in the
generated ChangeLog file, so they should preferably be no longer than
65 characters.

> * lisp/progmodes/php-ts-mode.el (php-ts-mode-css-fontify-colors):
>   New custom var.
 ^^^
Please don't leave this whitespace at the beginning of lines.

> * lisp/progmodes/php-ts-mode.el (php-ts-mode): Use the new function.

This line is also too long.

I usually correct any log messages that need it, but if you observe
these conventions better, it will make my job easier.

Thanks.





  reply	other threads:[~2024-06-23  5:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22 21:36 bug#71724: 30.0.50; [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region' Vincenzo Pupillo
2024-06-23  5:06 ` Eli Zaretskii [this message]
2024-06-23 10:11   ` Vincenzo Pupillo
2024-06-23 10:15     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86iky0fdtp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71724-done@debbugs.gnu.org \
    --cc=v.pupillo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).