* bug#71745: 29.3; Customize face re-selects unselected items, leading to broken
@ 2024-06-24 6:51 Sam Hedin
2024-06-24 12:51 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Sam Hedin @ 2024-06-24 6:51 UTC (permalink / raw
To: 71745
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
Once opening the customize buffer all checkboxes are selected by
default, even if they were de-selected by the user previously, which
means that the user may unintentionally change settings they didn't
intend to.
Emacs -Q -> M-x customize-face -> default -> deselect
Foreground/Background -> click Apply. Close the buffer, then open the
customization again. Note that the foreground/background checkboxes are
selected again.
The result of this is that using the customize buffer may have
unintended side effects. In my case, I opened the
customize buffer only to change the font, but accidentally defined a
foreground and background color in the process which led to some themes
breaking. This is most noticeable when opening the customize buffer when
using a light theme, saving, then loading a dark theme. For example
modus-operandi/modus-vivendi.
[-- Attachment #2: Type: text/html, Size: 931 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#71745: 29.3; Customize face re-selects unselected items, leading to broken
2024-06-24 6:51 bug#71745: 29.3; Customize face re-selects unselected items, leading to broken Sam Hedin
@ 2024-06-24 12:51 ` Eli Zaretskii
[not found] ` <CAKwytt_NX3=RpYrDdxhqZqNZ8Jhje8aHeWqwhs7mgSsSqKCY+w@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2024-06-24 12:51 UTC (permalink / raw
To: Sam Hedin; +Cc: 71745
> From: Sam Hedin <sam.hedin@gmail.com>
> Date: Mon, 24 Jun 2024 08:51:57 +0200
>
> Once opening the customize buffer all checkboxes are selected by
> default, even if they were de-selected by the user previously, which
> means that the user may unintentionally change settings they didn't
> intend to.
>
> Emacs -Q -> M-x customize-face -> default -> deselect
> Foreground/Background -> click Apply. Close the buffer, then open the
> customization again. Note that the foreground/background checkboxes are selected again.
Do you see this only for the default face or for other faces as well?
I can only reproduce this for the default face. Which looks correct
to me, because it is meaningless to uncheck any attributes of the
default face: the default face must always have all the attributes
specified explicitly.
> The result of this is that using the customize buffer may have
> unintended side effects. In my case, I opened the
> customize buffer only to change the font, but accidentally defined a
> foreground and background color in the process which led to some themes breaking. This is most noticeable
> when opening the customize buffer when using a light theme, saving, then loading a dark theme. For example
> modus-operandi/modus-vivendi.
Please show an example with some other face, and let's take it from
there.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-25 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 6:51 bug#71745: 29.3; Customize face re-selects unselected items, leading to broken Sam Hedin
2024-06-24 12:51 ` Eli Zaretskii
[not found] ` <CAKwytt_NX3=RpYrDdxhqZqNZ8Jhje8aHeWqwhs7mgSsSqKCY+w@mail.gmail.com>
2024-06-25 13:19 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).