From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71745: 29.3; Customize face re-selects unselected items, leading to broken Date: Mon, 24 Jun 2024 15:51:31 +0300 Message-ID: <86ikxybj1o.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71745@debbugs.gnu.org To: Sam Hedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 14:52:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLjBG-0004QS-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 14:52:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLjAw-0000zB-Mu; Mon, 24 Jun 2024 08:52:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLjAv-0000va-C9 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:52:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLjAv-0007fY-1o for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLjAv-0002CP-Qq for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71745 X-GNU-PR-Package: emacs Original-Received: via spool by 71745-submit@debbugs.gnu.org id=B71745.17192335038408 (code B ref 71745); Mon, 24 Jun 2024 12:52:01 +0000 Original-Received: (at 71745) by debbugs.gnu.org; 24 Jun 2024 12:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:56309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjAd-0002BV-1K for submit@debbugs.gnu.org; Mon, 24 Jun 2024 08:51:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjAa-0002BC-Ut for 71745@debbugs.gnu.org; Mon, 24 Jun 2024 08:51:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLjAU-0007c1-GX; Mon, 24 Jun 2024 08:51:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6h+uwNcU5EjW6bkEuFGlTYnSBD0YO3i4GvnQ6rt8J+0=; b=C6UO1J7XtV1r BEnuIOZWS7Ga4rA/8tFFs/NTVtZc3gtxIvYU0sDdbSLM8LryAwxZafPF1qHm5fnz8PuJxDuRgFtZd Fj0EdcAZSLHkVlZzX8bDOz2zTs2DdvlcxGrqi9k0YMp8pyTA5cnbnKxPRu3WHEH+ISwqxI7dDSZ0p rcOiJLkih3Atvgn9fc9NXbEUle/g61Qc38i7j+3a/iChn4PYeH6YcriK8DcmzNsHsvwe2mgRIDPNn WpaewyzH1a7tFisTuSAWysAoMX4RDquU1sbtXniLD3IDqQHLy/hrJ/2z/zSpxSQGqD4XC6c5Z+Wj2 Bi4uIcvzV77fW62fteHA3w==; In-Reply-To: (message from Sam Hedin on Mon, 24 Jun 2024 08:51:57 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287838 Archived-At: > From: Sam Hedin > Date: Mon, 24 Jun 2024 08:51:57 +0200 > > Once opening the customize buffer all checkboxes are selected by > default, even if they were de-selected by the user previously, which > means that the user may unintentionally change settings they didn't > intend to. > > Emacs -Q -> M-x customize-face -> default -> deselect > Foreground/Background -> click Apply. Close the buffer, then open the > customization again. Note that the foreground/background checkboxes are selected again. Do you see this only for the default face or for other faces as well? I can only reproduce this for the default face. Which looks correct to me, because it is meaningless to uncheck any attributes of the default face: the default face must always have all the attributes specified explicitly. > The result of this is that using the customize buffer may have > unintended side effects. In my case, I opened the > customize buffer only to change the font, but accidentally defined a > foreground and background color in the process which led to some themes breaking. This is most noticeable > when opening the customize buffer when using a light theme, saving, then loading a dark theme. For example > modus-operandi/modus-vivendi. Please show an example with some other face, and let's take it from there. Thanks.