From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking Date: Mon, 26 Aug 2024 14:32:35 +0300 Message-ID: <86ikvnjz8s.fsf@gnu.org> References: <26542402.1r3eYUQgxm@fedora> <9FFE9897-83A8-4760-8BFA-F1EDC4195D02@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 72796@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 26 13:33:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1siXyY-0008EG-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Aug 2024 13:33:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1siXyE-0007Jp-UW; Mon, 26 Aug 2024 07:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1siXyC-0007JX-W3 for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 07:33:13 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1siXyC-000542-BH for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 07:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=D1iNXTDYng/+4vZw/9WMuQaR191Tb+sjbP/510f/t4w=; b=QMo9cGDDJN5GuaCV5StXB/4CT88SfROidRxwwcMowROC7OFjRkguzIztocJPsDUZNCp3FJnGmzpwGGhBqxHfTTNASWDl5ranv9wRFoENlH6okfEgT+fV/UlPP+OAqiwwvHzqfZJeUv040tRs6GNHS0zCJOSyFSjW93CfxSwDwHuoeXeK98gvprQT/rcWfDmr70vCpIqooADdTPzdj/CVHpqoIjnB3S92Nwr8zoCgLVVprkcUWVtUrJM8KuGC88IbXQBbFzfeH92qZHw1ItUdmt4tj32DYLS1s33Z0MQROwFVmBcJFpbZECt1+L5aSkjgfIwBwWQbWTZ7FkzwhKc63Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1siXz0-0001vu-FK for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 07:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2024 11:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72796 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72796-submit@debbugs.gnu.org id=B72796.17246720187393 (code B ref 72796); Mon, 26 Aug 2024 11:34:02 +0000 Original-Received: (at 72796) by debbugs.gnu.org; 26 Aug 2024 11:33:38 +0000 Original-Received: from localhost ([127.0.0.1]:43820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siXyc-0001vB-Ay for submit@debbugs.gnu.org; Mon, 26 Aug 2024 07:33:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siXya-0001uv-H4 for 72796@debbugs.gnu.org; Mon, 26 Aug 2024 07:33:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1siXxe-00052z-LO; Mon, 26 Aug 2024 07:32:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D1iNXTDYng/+4vZw/9WMuQaR191Tb+sjbP/510f/t4w=; b=D/CtBTPLWw0H M+61JSi7kgmzfBke7D9sb8eSg0KluM59XYcA1zw88YqSul2TzcGlx0OiC83lpH9GrCnT+AYFkHWTv z4OGB1cINWyrMxX6cvJqD1fGALL5TwFA0YE2RthkwN0mYiJO3Df7o+qrcRXh+TroTG1p2fLYWiNWe W/YBngPgtj4OQgKhBpX03xQX+tiOhQK7/Xn5cjL3kTSyPAinsbT2wznZzZ9HO6x1eFRMcBbxh6ul6 Vx1MLLdWJwo9UklrnC/lyoj2Ng4TYYIfSVHPXQas/TdotNEcp5eIa+W5k07J3jL8Yl+z2Z8R6sr4E pyk6/94dFEMk1rgq9YdJ6g==; In-Reply-To: (message from Vincenzo Pupillo on Mon, 26 Aug 2024 12:16:23 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290781 Archived-At: > Cc: 72796-done@debbugs.gnu.org > From: Vincenzo Pupillo > Date: Mon, 26 Aug 2024 12:16:23 +0200 > > Since php-ts-mode is not available in emacs-29 and emacs-30 has not been released, perhaps it is better to > support grammars from the release date. Or is it better to support from the date of the first merge? I have no > idea which is the best policy. We cannot be sure that users of this mode will necessarily have the latest grammar library. It depends on various factors, like the installation policies on the user's system. So I think it's best to be tolerant to the version of the grammar, if this is feasible.