From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73452: Code lens support in eglot Date: Wed, 25 Sep 2024 14:31:20 +0300 Message-ID: <86ikukc6lz.fsf@gnu.org> References: <05f4d679-d2cd-409c-aafd-bfac2eda7a21@fbengineering.ch> <86v7ylcatg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27897"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73452@debbugs.gnu.org, federico.beffa@fbengineering.ch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 25 13:31:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stQFL-00076z-6I for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Sep 2024 13:31:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stQFB-0006Pw-UI; Wed, 25 Sep 2024 07:31:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stQF7-0006ES-CM for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 07:31:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stQF7-0006RF-2x for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 07:31:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=N9VBf4/gPXy0gvf1+snbTLwUPD0FVh62GOIARubOzmg=; b=O+9gX0ZvRKjto1V2hAIM33/Csf+CZwBtQcggbZDBCHoHaCWrWtOQkSwtCi1uMx2xKTjaJVWf64XMYE05uOZN7H6Z9NbFXHPhavtks1USeGIQ2J7/RWtqv3K3FNLAkvNQyCK2N+5aYNz4wAtSR0pveiu3RdqooElRkVRXFvNUyzFq97Uuev+JDfeDrqY4lDpbiVuWk5bsGXyCz+lL+rTuvfRqJtYCfgXkUanMGoSuo1187DHFAunHXw8PbeTMRTIqXSn8kgiEU06xz2+q9gBlu+kfRLNgs1GijY45NLDXAgQ/UrSwtd4Ek51DWlAZK0ADPs1TTeZ7inIMd8ZPjblI0A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stQFW-0002GC-Ms for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2024 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73452 X-GNU-PR-Package: emacs Original-Received: via spool by 73452-submit@debbugs.gnu.org id=B73452.17272639188675 (code B ref 73452); Wed, 25 Sep 2024 11:32:02 +0000 Original-Received: (at 73452) by debbugs.gnu.org; 25 Sep 2024 11:31:58 +0000 Original-Received: from localhost ([127.0.0.1]:57628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stQFR-0002Fr-NO for submit@debbugs.gnu.org; Wed, 25 Sep 2024 07:31:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stQFP-0002Fa-6A for 73452@debbugs.gnu.org; Wed, 25 Sep 2024 07:31:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stQEs-0006Q1-VF; Wed, 25 Sep 2024 07:31:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=N9VBf4/gPXy0gvf1+snbTLwUPD0FVh62GOIARubOzmg=; b=N+SBcXZtcCx0Dd5nzs9G QWja9ayuKsE4S60nb0mbvSUrTCAtGb6u7manrZJzs2c6NWKtA9FoXWepkhPGtG0CjzEoNznE9KJki tPzPDBKyOF8mA2Y3UbpiqrLai3fqTOs1nKaR2O5BSrXsiifhHprNg5Q7HS65pH4wHWBZ+2JGzu8/9 U9aBPSNu8Yb3tLtrIEFdd5tqmwexhyv1zt6bB09TCWO3rPVWqO3uXfcbUuSn+O1FADuvNa3Hyqa5h W+yV4RFlzjt8ndhNsVVgdmgSp26xGD3xm6U+XKRQGfAiCTQ+t6Eb7XBMJn1FMwnyuGmwpHQxetGS2 aUdL29rpH7MC6Q==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Tue, 24 Sep 2024 22:01:02 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292385 Archived-At: > From: João Távora > Date: Tue, 24 Sep 2024 22:01:02 +0100 > Cc: federico.beffa@fbengineering.ch, 73452@debbugs.gnu.org > > > What infrastructure would be needed? > > It's not easy to describe, you'd have to be very familiar with how > code lens work on VSCode and Visual Studio (I'm not). It's a cross > between Flymake and Eglot's custom inlay hints. > > The lower-level infrastructure (buttons, overlays, jit-lock-register) exists > and is probably enough for a decent experience (though there are > the typical annoying flaws with overlays and jit-lock-register). The problem > is knowing how to tie this together in an sensible and robust infrastructure > that Eglot (or other providers) can plug into. An abstraction that will model > something presumably more useful and practical than what is already > available through other existing Emacs means (vc-* commands, M-x compile, > Eglot code actions). Then maybe someone could describe such an abstraction. > Read the last parts of the discussion I linked to if you're > interested. I did, but couldn't answer my questions, because the discussion relies heavily on VSCode features with which I'm not familiar and whose descriptions I saw didn't clarify the issue.