From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 73838@debbugs.gnu.org
Subject: bug#73838: 31.0.50; Problems in note_mouse_highlight if -nw
Date: Thu, 17 Oct 2024 07:06:33 +0300 [thread overview]
Message-ID: <86iktrpe46.fsf@gnu.org> (raw)
In-Reply-To: <m2ldyng9ak.fsf@gmail.com> (message from Gerd Möllmann on Wed, 16 Oct 2024 21:03:15 +0200)
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: 73838@debbugs.gnu.org
> Date: Wed, 16 Oct 2024 21:03:15 +0200
>
> > Thus, IMO your suggestion is in a sense a step back, because it
> > assumes that TTY frames can never have these decorations and can never
> > have different cursor types. So my suggestion would be to do the
> > opposite: understand why FRAME_OUTPUT_DATA segfaults when dereferenced
> > on TTY frames, and fix that so that it doesn't.
>
> But the current situation is that we follow from the presence of an
> internal border that it's a window system frame. We're using
> FRAME_OUTPUT_DATA. If that would segv it would be a good thing. It
> doesn't do that, it just silently accesses some unrelated memory (in my
> case this is equivalent to casting the actual output_data contents to
> (struct ns_output *) regardless of what it actually is.
>
> I've just dragged the FRAME_WINDOW_P out of this stuff because the
> whole if-statement is concerned with cursor = ... using FRAME_OUTPUT_DATA.
My suggestion is to extend 'struct tty_display_info' so that
FRAME_OUTPUT_DATA on TTY frames will not access unrelated memory, when
these macros/inline functions are called. Alternatively, we could have
the macros/functions (FRAME_INTERNAL_BORDER etc.) test for TTY frame
and DTRT.
next prev parent reply other threads:[~2024-10-17 4:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:47 bug#73838: 31.0.50; Problems in note_mouse_highlight if -nw Gerd Möllmann
2024-10-16 14:19 ` Gerd Möllmann
2024-10-16 15:38 ` Eli Zaretskii
2024-10-16 16:56 ` Gerd Möllmann
2024-10-16 18:30 ` Eli Zaretskii
2024-10-16 19:03 ` Gerd Möllmann
2024-10-17 4:06 ` Eli Zaretskii [this message]
2024-10-17 5:07 ` Gerd Möllmann
2024-10-17 5:48 ` Eli Zaretskii
2024-10-17 7:03 ` Gerd Möllmann
2024-10-17 10:44 ` Eli Zaretskii
2024-10-17 12:12 ` Gerd Möllmann
2024-10-17 10:46 ` Eli Zaretskii
2024-10-17 12:39 ` Gerd Möllmann
2024-10-19 3:50 ` Gerd Möllmann
2024-10-19 8:00 ` Gerd Möllmann
2024-10-16 15:27 ` Eli Zaretskii
2024-10-16 16:41 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86iktrpe46.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73838@debbugs.gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).