From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Tue, 24 Dec 2024 14:44:40 +0200 Message-ID: <86ikr92qtj.fsf@gnu.org> References: <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> <867c8af514.fsf@gnu.org> <86ldwpedud.fsf@gnu.org> <86r05z67gm.fsf@gnu.org> <86wmfp3gh4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, yantar92@posteo.net, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 24 13:45:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ4Ho-0007Fi-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Dec 2024 13:45:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ4Ha-0001dq-Rv; Tue, 24 Dec 2024 07:45:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ4HX-0001dg-3T for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 07:45:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQ4HW-0008WJ-PU for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 07:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=j3oZyRv4dPGYg/sHODLyy0pkWllVPNgheLc0MyHzPkY=; b=KnIl0iRiGmi3x9ubDiddawTzpvzQGt0wOKlvB7vsyhMOTGOF56XBY/2/JO7BXRiov81XlvYzHc7zTQl17iCCqWENEi9lh0MIx6xAB1E4LeChHnZzacmBmEZEJvGqAmRP1DdSRiKTxX5ipJ/Xn+DdOwXckelrz5fDs49jAwYIYDkyMleIqjO39u0OhGHg6ouzDwOT3Q7JvqQJ+XuA5zCpr66YU3JbAjO7HssX0oy0kiBGvZFUDxIYwSYWdzEYmPpQHfsxhfqdD+Fkt7qZNgj03H5Z9PvvvQm8xrJ7QluHUT57KiRpOr3qNfbJpGah/mYYLgJIM0LeXT+QPJKoQ3Ai7A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQ4HW-0006Wd-0c for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2024 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173504429925059 (code B ref 73862); Tue, 24 Dec 2024 12:45:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 24 Dec 2024 12:44:59 +0000 Original-Received: from localhost ([127.0.0.1]:59870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQ4HS-0006W7-Ge for submit@debbugs.gnu.org; Tue, 24 Dec 2024 07:44:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQ4HO-0006Vs-B9 for 73862@debbugs.gnu.org; Tue, 24 Dec 2024 07:44:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ4HH-0008UQ-PU; Tue, 24 Dec 2024 07:44:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j3oZyRv4dPGYg/sHODLyy0pkWllVPNgheLc0MyHzPkY=; b=hmLNHEBtf4VU zR5UDd/9nzAazQblQlyrqBZTkEMjyATljm/3axSvOnsFUVkm/7JEVDwEeAW+jlry/rgHluLfPkoIX bTo7Jpkq0on2BjzQqsAaR0SZ8jBhCu9Cif4ketp8f4i19GqfWgkpv4qHdEwmbSQoDX4fNJzbGGhm9 MLE6EmHj8ohuP0ynHOp/0zX9pMszpB2C8k9nXexrbgam0oSeyQFGma2DDFE63iSi+Bp5T3uy0nQqV ArvgZk/z6ase4qglpRCEbfmmTX/EvQO6Kuu4+lhLboy/divPPvHQnfJx9gBqo0Z9EVUpVuxTo3ixz 4aglTio7o57SJairbLpshQ==; In-Reply-To: (message from Aaron Jensen on Mon, 23 Dec 2024 21:17:16 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297693 Archived-At: > From: Aaron Jensen > Date: Mon, 23 Dec 2024 21:17:16 -0800 > Cc: me@eshelyaron.com, trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, > 73862@debbugs.gnu.org, yantar92@posteo.net > > Are there any tradeoffs with this approach other than additional code complexity? Any > performance concerns? > > I didn't time the code. It is a bit more expensive, but I don't know by how much. Maybe you could see > what happens in a session with lots and lots of faces and report? > > Does the change impact anything more than the infrequent basic face calculation (whatever the thing was > we were triggering by changing the default face size) or is it in the standard render path? It affects realization of basic faces and also their lookup (by face ID, which is what the display engine uses). But these two operations are not so rare. In particular, any change of attributes of a "named face" (a face identified by its symbol) will usually cause us free and re-realize all of the frame's faces, including the basic ones. Given what current Lisp programs like to do, this happens surprisingly frequently. And face look up happens every time a window is redisplayed.