unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Branislav Zahradník" <happy.barney@gmail.com>
Cc: 74509@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#74509: Feature request - smerge-mode
Date: Sat, 04 Jan 2025 13:43:18 +0200	[thread overview]
Message-ID: <86ikquere1.fsf@gnu.org> (raw)
In-Reply-To: <CAB=rbO=qEp+wk5EU27we5s0Dr3zDWV3TmR83JO0atk4kH_TnVw@mail.gmail.com> (message from Branislav Zahradník on Sun, 22 Dec 2024 10:46:17 +0100)

> From: Branislav Zahradník <happy.barney@gmail.com>
> Date: Sun, 22 Dec 2024 10:46:17 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, 74509@debbugs.gnu.org
> 
> On Sun, 22 Dec 2024 at 03:54, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>  >> How should we go about this bug report?
>  >> Can we make some progress here?  Or should we close it as wontfix?
>  > No, I think his commands make sense.  We just need to improve them so
>  > they also work with 3-part conflicts.
> 
>  I just pushed to `master` a version of `smerge-extend` which can
>  incorporate both following and preceding lines, and works with both
>  diff2 and diff3 style conflicts.
> 
>  The OP also suggested binding this new command as well as `smerge-swap`
>  in the SMerge minor mode map (to `C-c ^ x` and `C-c ^ s` respectively).
>  That would shadow `M-x` and `M-s` (when `smerge-mode` is active) for
>  users who configured `smerge-command-prefix` to be ESC, so I think that
>  could be problematic.  For that reason, I did not include that part.
> 
> Thank you very much. Such code is at the moment beyond my elisp capabilities :-)
> 
> Key bindings were "nice to have", it's not a problem to configure it manually.
> With current implementation I'd probably have two bindings anyway.
> 
> I will think about bindings and will come with suggestion later (if/when I will have something usable)

Should we close this bug or should we leave it open?





  reply	other threads:[~2025-01-04 11:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24  8:17 bug#74509: Feature request - smerge-mode Branislav Zahradník
2024-11-30 10:28 ` Eli Zaretskii
2024-12-01 23:51   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02  7:59     ` Branislav Zahradník
2024-12-03  3:26       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-03  6:39         ` Branislav Zahradník
2024-12-21  8:47           ` Eli Zaretskii
2024-12-21 15:11             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22  2:54               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22  9:46                 ` Branislav Zahradník
2025-01-04 11:43                   ` Eli Zaretskii [this message]
2025-01-18  9:20                     ` Eli Zaretskii
2025-01-18 23:30                       ` Branislav Zahradník
2025-01-19  5:52                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ikquere1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74509@debbugs.gnu.org \
    --cc=happy.barney@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).