From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Thu, 07 Oct 2021 22:04:33 +0100 Message-ID: <86h7dszgv2.fsf@gmail.com> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) To: 51037@debbugs.gnu.org Cancel-Lock: sha1:/VM6gN2emb3fx7ZDTxcXeN8/r0o= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 07 23:05:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYaZl-00071T-Cf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 23:05:13 +0200 Original-Received: from localhost ([::1]:59480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYaZj-00033s-E2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 17:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYaZb-00031q-7E for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 17:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYaZa-0006tE-Tw for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 17:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYaZa-0005jj-Gv for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 17:05:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <86tuhvmtpl.fsf@runbox.com> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 21:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163364069322033 (code B ref -1); Thu, 07 Oct 2021 21:05:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Oct 2021 21:04:53 +0000 Original-Received: from localhost ([127.0.0.1]:48545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYaZR-0005jJ-6b for submit@debbugs.gnu.org; Thu, 07 Oct 2021 17:04:53 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYaZM-0005j6-6p for submit@debbugs.gnu.org; Thu, 07 Oct 2021 17:04:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYaZM-0002hn-1f for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 17:04:48 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:35066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYaZK-0004OS-HU for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 17:04:47 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mYaZH-0006J9-0e for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 23:04:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216685 Archived-At: On Thu 07 Oct 2021, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> Why do we limit print-length in batch mode? In interactive session, >> one can click or type RET on the ellipsis and get it expanded, but no >> such joy in batch. See >> >> https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg00395.html >> >> for how that makes debugging more difficult than it has to be. >> >> So how about using huge values in batch? Are there any downsides? > > It'll make the error summaries completely unreadable, which isn't what > you want when doing a "make check" -- you just want to see that there's > a problem and where it is. (Well, at least I do.) > > But when making a specific test (i.e., "make subr-tests" etc) it would > indeed be nice to have untruncated backtraces. I think adding these new > variables would allow us to do this. Isn't that what ert-batch-backtrace-right-margin is for ? (defcustom ert-batch-backtrace-right-margin 70 "Maximum length of lines in ERT backtraces in batch mode. Use nil for no limit (caution: backtrace lines can be very long)." :type '(choice (const :tag "No truncation" nil) integer)) Also the TEST_BACKTRACE_LINE_LENGTH environment variable can be used to set it (see test/Makefile.in). AndyM