From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Sat, 15 Jan 2022 21:12:53 +0200 Organization: LINKOV.NET Message-ID: <86h7a424p6.fsf@mail.linkov.net> References: <87y23hl729.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12370"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: ndame , 53255@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 20:18:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8oYz-00035l-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 20:18:09 +0100 Original-Received: from localhost ([::1]:42760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8oYy-00081M-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 14:18:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8oXu-000707-Hi for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8oXu-0000vu-89 for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8oXu-00058u-0b for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.164227417019684 (code B ref 53255); Sat, 15 Jan 2022 19:17:01 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 15 Jan 2022 19:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:41771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8oX4-00057Q-Jk for submit@debbugs.gnu.org; Sat, 15 Jan 2022 14:16:10 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:46013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8oX2-00056v-Di for 53255@debbugs.gnu.org; Sat, 15 Jan 2022 14:16:09 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3C658240007; Sat, 15 Jan 2022 19:16:00 +0000 (UTC) In-Reply-To: <87y23hl729.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Jan 2022 09:46:54 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224333 Archived-At: >> Like read-color shows the color names with their actual colors, the >> selection of a face should also show the names with their properties >> applied. > > The patch below implements this, but it does lead to some strange > effects: > > That is, some faces have odd sizes, so the completion display may look a > bit odd. > > But it does accurately tell you what the result is doing to be, so > perhaps it's OK? Anybody have any opinions? Whereas highlight-regexp can use all faces, the preferable faces are in hi-lock-face-defaults, so they need to be displayed separately.