From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Sun, 20 Mar 2022 22:29:51 +0200 Organization: LINKOV.NET Message-ID: <86h77s2wqo.fsf@mail.linkov.net> References: <87sftyweb2.fsf@gmail.com> <861r1iyrvw.fsf@mail.linkov.net> <87zgo6owaf.fsf@gmail.com> <86k0f9xnrn.fsf@mail.linkov.net> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86sfrjia5u.fsf@mail.linkov.net> <87ilseyks7.fsf@gmail.com> <868rt9wwji.fsf@mail.linkov.net> <871qz11w82.fsf@gmail.com> <86ilsc7e31.fsf@mail.linkov.net> <87tubwz9dd.fsf@gmail.com> <86sfrc2zr8.fsf@mail.linkov.net> <87o820iedv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53126@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 20 21:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nW2Dl-0001Hk-1U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 21:32:13 +0100 Original-Received: from localhost ([::1]:49290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nW2Di-0007L7-TG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 16:32:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nW2Da-0007J3-FX for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 16:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nW2Da-00077Q-6N for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nW2Da-0004Jc-2E for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164780831816578 (code B ref 53126); Sun, 20 Mar 2022 20:32:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 20 Mar 2022 20:31:58 +0000 Original-Received: from localhost ([127.0.0.1]:35195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2DW-0004JK-94 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 16:31:58 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2DV-0004J8-Ag for 53126@debbugs.gnu.org; Sun, 20 Mar 2022 16:31:57 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id F41A8C0003; Sun, 20 Mar 2022 20:31:49 +0000 (UTC) In-Reply-To: <87o820iedv.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 20 Mar 2022 20:59:40 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228637 Archived-At: >> Could you please split it to more logically separate patches? >> >> 1. a patch that removes checks for 'isearch-mode (null isearch-message-function)' >> and adds '(setq-local isearch-lazy-count nil)'. >> It could also contain more changes in comint.el etc >> from your earlier patch from 14 May 2021. >> >> 2. a patch that adds and runs 'lazy-count-update-hook'. >> >> 3. a patch with minibuffer-lazy-highlight feature in isearch.el. >> >> Then what will remain to do is to decide how it would be better to activate >> the minibuffer-lazy-highlight feature. > > Okay. Points 1 and 2 are hard to disentangle, and 1 strictly is only > necessary because of 2. Also, separating things further risks > introducing bugs in code that has been tested quite a bit by now. > > So my patch 00001 is for your points 1 and 2, patch 0002 is for point 3, > and patch 0003 adds lazy highlight to isearch-edit-string, where I guess > there is no controversy about what the configuration variables should > be. Thanks, pushed now, with a NEWS entry.