From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#21634: text-scale-adjust suggestion Date: Wed, 06 Jul 2022 20:42:20 +0300 Organization: LINKOV.NET Message-ID: <86h73uqs1j.fsf@mail.linkov.net> References: <22035.47283.76000.848103@gargle.gargle.HOWL> <83d1wsxcuz.fsf@gnu.org> <87zgstyl9e.fsf_-_@gnus.org> <871r65ab7q.fsf@mail.linkov.net> <87czpou8z7.fsf@gnus.org> <86letewfpa.fsf@mail.linkov.net> <878rpdyyxo.fsf@gnus.org> <86k08wzx5e.fsf@mail.linkov.net> <87r1333etw.fsf@gnus.org> <86wncu6t6b.fsf@mail.linkov.net> <87h73x882a.fsf@gnus.org> <86h73weppw.fsf@mail.linkov.net> <87pmij6c9t.fsf@gnus.org> <87a69nitkk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39607"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Eli Zaretskii , Eli Barzilay , 21634@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 19:44:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o994Q-000A8O-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 19:44:14 +0200 Original-Received: from localhost ([::1]:57222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o994P-00064G-QP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 13:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o994E-00063s-OH for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 13:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o994E-0005P7-3Q for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 13:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o994E-0007ZX-0P for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 13:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21634 X-GNU-PR-Package: emacs Original-Received: via spool by 21634-submit@debbugs.gnu.org id=B21634.165712939029035 (code B ref 21634); Wed, 06 Jul 2022 17:44:01 +0000 Original-Received: (at 21634) by debbugs.gnu.org; 6 Jul 2022 17:43:10 +0000 Original-Received: from localhost ([127.0.0.1]:55044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o993N-0007YE-OG for submit@debbugs.gnu.org; Wed, 06 Jul 2022 13:43:09 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o993J-0007XV-Ne for 21634@debbugs.gnu.org; Wed, 06 Jul 2022 13:43:08 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id DA257240004; Wed, 6 Jul 2022 17:42:57 +0000 (UTC) In-Reply-To: <87a69nitkk.fsf@gmail.com> (Robert Pluim's message of "Tue, 05 Jul 2022 15:21:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236281 Archived-At: > >> format-spec is a nice helper. Here are the changes after > >> the value of %k is automatically generated from the keys: > >> > >> emoji-zoom-increase: > >> OLD: Zoom with + and - > >> NEW: Zoom with +, - > >> > >> indent-rigidly: > >> OLD: Indent region with , , S-, or S-. > >> NEW: Indent region with TAB, , , S-, S- > > Lars> I think the final ", " in these lists should be an " or " instead -- I > Lars> think that reads better. > > Yes Should then describe-repeat-maps do the same and replace this next-error (bound to n, M-n) previous-error (bound to p, M-p) with next-error (bound to n or M-n) previous-error (bound to p or M-p) Then also should repeat-echo-message-string use "or" and replace Repeat with n, M-n with Repeat with n or M-n But doing this is problematic since when repeat-exit-key is defined, it will also replace Repeat with n, M-n or exit with RET with incorrect Repeat with n or M-n or exit with RET > >> global-text-scale-adjust: > >> OLD: Use +,-,0 for further adjustment > >> NEW: Use +, =, -, 0, ESC for further adjustment > >> > >> ESC is because map-keymap handles only top-level keys > >> but C-M-+ is [ESC C-+]. > > Lars> Hm. We don't have any function that'll just spit out all the "real" key > Lars> binding in a keymap somewhere? I.e., that results in a list with keys a > Lars> la what's displayed by `C-h b'? I guess not, but that sounds like a > Lars> useful utility function to have, and could be used here. > > I think the guts of `describe-repeat-mapsʼ does something like that. I forgot that describe-repeat-maps uses where-is-internal. But I don't see how repeat-echo-message-string and set-transient-map could use where-is-internal without iterating a huge list of all commands from obarray. There is no function to get all commands from the given keymap only? BTW, now I fixed describe-repeat-maps to handle the case when the keymap is not a symbol, e.g. (put 'next-line 'repeat-map (define-keymap "C-M-a" #'next-line "C-M-b" #'next-line)) Also pushed new args of set-transient-map, so the same improvements are needed for both repeat-echo-message-string and set-transient-map, maybe by sharing the same code.