From: Stephen Leake <stephen_leake@stephe-leake.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56606@debbugs.gnu.org
Subject: bug#56606: Acknowledgement (29.0.50; recent master fails with "creating pipe: too many open files")
Date: Mon, 18 Jul 2022 17:04:05 -0700 [thread overview]
Message-ID: <86h73ex91m.fsf@stephe-leake.org> (raw)
In-Reply-To: <831qujrjnm.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Jul 2022 15:46:53 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 56606@debbugs.gnu.org
>> Date: Sun, 17 Jul 2022 13:20:12 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>>
>> > From: Stephen Leake <stephen_leake@stephe-leake.org>
>> > Date: Sun, 17 Jul 2022 02:42:04 -0700
>> >
>> > On emacs-devel, Eli said:
>> >
>> > AFAICT, this loop in deactivate_process:
>> >
>> > /* Beware SIGCHLD hereabouts. */
>> >
>> > for (i = 0; i < PROCESS_OPEN_FDS; i++)
>> > close_process_fd (&p->open_fd[i]);
>> >
>> > doesn't close the last of the 4 descriptors opened by the 2 emacs_pipe
>> > calls in make-pipe-process. It calls 'close' with the right value,
>> > and close returns zero, but the pipe stays open. In Emacs 28, this
>> > same loop successfully closes the descriptor. I don't know why.
>> >
>> > Perhaps bisecting could help.
>>
>> I think commit a81669c could be the culprit.
>
> I hope I fixed this now on master.
>
Yes, it is fixed, by 637436970f34f860d50f73a514b3bafd0c5cace7.
--
-- Stephe
next prev parent reply other threads:[~2022-07-19 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 21:49 bug#56606: 29.0.50; recent master fails with "creating pipe: too many open files" Stephen Leake
[not found] ` <handler.56606.B.165800822832001.ack@debbugs.gnu.org>
2022-07-17 9:42 ` bug#56606: Acknowledgement (29.0.50; recent master fails with "creating pipe: too many open files") Stephen Leake
2022-07-17 10:20 ` Eli Zaretskii
2022-07-17 12:46 ` Eli Zaretskii
2022-07-19 0:04 ` Stephen Leake [this message]
2022-07-19 2:38 ` Eli Zaretskii
2022-07-18 23:54 ` Stephen Leake
2022-07-19 0:05 ` bug#56606: 29.0.50; recent master fails with "creating pipe: too many open files" Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h73ex91m.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=56606@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).