From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#61535: 29.0.60; choose-completion erases in-region buffer Date: Sat, 18 Feb 2023 20:43:21 +0200 Organization: LINKOV.NET Message-ID: <86h6vilsqe.fsf@mail.linkov.net> References: <86y1oylrap.fsf@mail.linkov.net> <83ilg2afip.fsf@gnu.org> <86edqpebxy.fsf@mail.linkov.net> <83bklt2wz6.fsf@gnu.org> <86bklsem93.fsf@mail.linkov.net> <83mt5c1ydo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25744"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 61535@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 19:51:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTSIx-0006XP-24 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 19:51:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTSIZ-0000Qj-LZ; Sat, 18 Feb 2023 13:51:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTSIY-0000QR-7F for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 13:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTSIX-0007ln-Uv for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 13:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTSIX-0006wS-Ne for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 13:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61535 X-GNU-PR-Package: emacs Original-Received: via spool by 61535-submit@debbugs.gnu.org id=B61535.167674622226615 (code B ref 61535); Sat, 18 Feb 2023 18:51:01 +0000 Original-Received: (at 61535) by debbugs.gnu.org; 18 Feb 2023 18:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:44961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTSHu-0006vD-2H for submit@debbugs.gnu.org; Sat, 18 Feb 2023 13:50:22 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:60329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTSHs-0006uv-7X for 61535@debbugs.gnu.org; Sat, 18 Feb 2023 13:50:20 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C1DF440006; Sat, 18 Feb 2023 18:50:12 +0000 (UTC) In-Reply-To: <83mt5c1ydo.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Feb 2023 10:37:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255986 Archived-At: >> >> >> 1. type: (with-c C-M-i >> >> >> 2. type: M-down ... M-RET >> >> Actually, this is not an old problem. It's in a new feature added in 29.1. > > Hmmm... I don't think I see that. Both completion-in-region-mode and > the condition at that place haven't changed in a while. The addition > of completion-use-base-affixes part is new, but since it's via 'and', > it cannot have changed what the code before did, only cause it to do > that in fewer cases. What am I missing? 'M-RET' above is new. It's bound to the new function 'minibuffer-choose-completion' that let-binds 'completion-use-base-affixes' to t that works only in the minibuffer, not in 'completion-in-region-mode'. >> And this patch fixes the new feature. This is different from a similar >> problem fixed now in bug#61479 that is really an old problem. > > This is all undecipherable for me, sorry. What is that "new feature", > and how is it fixed here? New feature is 'M-RET', 'minibuffer-choose-completion', 'completion-use-base-affixes'. What is fixed here is their interaction. > And how is bug#61479 relevant? It's an example of a bug fixed in an old feature.