From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Mon, 05 Jun 2023 09:53:39 +0300 Organization: LINKOV.NET Message-ID: <86h6rmpf1s.fsf@mail.linkov.net> References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> <83ttvqbch1.fsf@gnu.org> <86v8g6uzdj.fsf@mail.linkov.net> <83leh2ayai.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34281"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, 63648@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 09:07:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q64JC-0008hF-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 09:07:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q64Iy-00012V-8d; Mon, 05 Jun 2023 03:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q64Iw-000124-8v for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q64Iw-00084x-0X for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q64Iv-0000GD-S4 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 03:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 07:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.1685948764931 (code B ref 63648); Mon, 05 Jun 2023 07:07:01 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 5 Jun 2023 07:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:47889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q64Hz-0000Ex-RD for submit@debbugs.gnu.org; Mon, 05 Jun 2023 03:06:04 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q64Hy-0000E7-A8 for 63648@debbugs.gnu.org; Mon, 05 Jun 2023 03:06:02 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id C254F20005; Mon, 5 Jun 2023 07:05:54 +0000 (UTC) In-Reply-To: <83leh2ayai.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Jun 2023 14:39:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262992 Archived-At: >> >> @@ -1500,7 +1500,19 @@ command_loop_1 (void) >> >> update_redisplay_ticks (0, NULL); >> >> display_working_on_window_p = false; >> >> >> >> + Lisp_Object next_dir = Vnext_default_directory; >> >> + specpdl_ref count = SPECPDL_INDEX (); >> >> + if (!NILP (next_dir)) >> >> + specbind (Qdefault_directory, next_dir); >> >> + >> >> call1 (Qcommand_execute, Vthis_command); >> >> + >> >> + if (!NILP (next_dir)) >> >> + { >> >> + unbind_to (count, Qnil); >> >> + Vnext_default_directory = Qnil; >> >> + } >> >> + >> > >> > What will this do when a command is invoked via call-interactively? >> >> This is intended only for commands called interactively. > > Won't this violate some legitimate expectations? Namely, that > invoking a command interactively and via call-interactively produces > the same results? Using 'let' for 'call-interactively' works expectedly in the recent patch: (if (symbolp project-switch-commands) (let ((default-directory dir)) (call-interactively project-switch-commands))