From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Sat, 28 Oct 2023 19:56:08 +0300 Organization: LINKOV.NET Message-ID: <86h6mag077.fsf@mail.linkov.net> References: <86il88x9cy.fsf@mail.linkov.net> <4367c45c-95b3-6a29-4ba3-068a3c748452@gutov.dev> <2e34e515-a921-a969-0915-bea94c745f8b@gutov.dev> <868r9258oi.fsf@mail.linkov.net> <86edishisp.fsf@mail.linkov.net> <6fc81cbf-a21f-c5b4-aa56-e8518b8570d7@gutov.dev> <86msxgatuy.fsf@mail.linkov.net> <86y1gynr2u.fsf@mail.linkov.net> <7c72fd8c-c3f6-a974-8a4b-a081f7a9fe1a@gutov.dev> <86ttqmv7c6.fsf@mail.linkov.net> <56e7d865-0456-db7d-3a5d-1235e62508bf@gutov.dev> <865y31onju.fsf@mail.linkov.net> <8562bdad-e487-886a-af49-7f67d8d14b7a@gutov.dev> <86msw9g5yb.fsf@mail.linkov.net> <56909bdd-14ee-f68c-178f-5057efcd6150@gutov.dev> <86wmva7iey.fsf@mail.linkov.net> <86bkckwnf8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Spencer Baugh , 63648@debbugs.gnu.org, sbaugh@catern.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 28 19:07:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwmmv-0005Ds-B9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Oct 2023 19:07:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwmme-00068O-1Z; Sat, 28 Oct 2023 13:07:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwmmb-00066t-AC for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 13:07:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwmmY-0005Rn-QF for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 13:07:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwmn4-0000bF-GR for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2023 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.16985128712267 (code B ref 63648); Sat, 28 Oct 2023 17:08:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 28 Oct 2023 17:07:51 +0000 Original-Received: from localhost ([127.0.0.1]:39470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwmms-0000aV-Vc for submit@debbugs.gnu.org; Sat, 28 Oct 2023 13:07:51 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwmmq-0000aE-O5 for 63648@debbugs.gnu.org; Sat, 28 Oct 2023 13:07:49 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 0B425C0002; Sat, 28 Oct 2023 17:07:08 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Fri, 27 Oct 2023 12:38:50 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273455 Archived-At: >>>>> + ;; Variation: could be a separate command, or an option. >>>>> + ;; (command (let ((overriding-local-map project-prefix-map)) >>>>> + ;; (key-binding (read-key-sequence >>>>> + ;; (format "[execute in %s]:" (project-root pr))) >>>>> + ;; t))) >>>> Thanks, it works nicely. >>>> Any reason not to use this by default? >>> >>> Nothing critical, but it might not fit the expectations without additional >>> instructions in the prompt, or it can be unnecessary if the user had >>> reached this command through 'C-x p o'. >> Indeed, this is needed only for 'C-x p p' that supports the global map. >> >>> In the latter case there is also a small chance that the user had set up >>> some advanced sub-maps inside project-prefix-map which would shadow some >>> global bindings. So maybe a separate command is best. Please see how you >>> like the attached new version together with >>> >>> (setq project-switch-commands #'project-prefix-or-any-command) >> A separate command that is not used anywhere looks strange. >> Why not a simple option like 'project-switch-use-entire-map'? > > You would still need to change project-switch-commands, right? Or what > would the option be called? I expected 'project-switch-use-global-map' to be used by 'project--switch-project-command' without the need to customize 'project-switch-commands'. >>> I'm not sure about project-prefix-or-any-command's prompt, though (phrasing >>> feels awkward). Improvements welcome. >> I'm not a fan of the long prompt especially that wraps to the second >> line. > > It didn't wrap for me. Because the length depends on the deepness of the project root. > But if it's too long, how would you like it changed? > Remove everything? Just keep [executing in ...]? I'd prefer keeping only [executing in ...] because it's useful to confirm in which directory the command will be executed. But all available keys are usually useless except in such modes as help-quick for novices.