From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Date: Mon, 26 Feb 2024 18:52:41 +0200 Message-ID: <86h6hvuq06.fsf@gnu.org> References: <86y1b7uy1b.fsf@gnu.org> <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 69405@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 26 18:12:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reeWg-00075a-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Feb 2024 18:12:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reeV4-00058d-In; Mon, 26 Feb 2024 12:10:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reeUw-0004yl-Db for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 12:10:38 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reeUw-0002KM-4V for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 12:10:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reeVL-0001lI-GK for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 12:11:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2024 17:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69405-submit@debbugs.gnu.org id=B69405.17089674206620 (code B ref 69405); Mon, 26 Feb 2024 17:11:03 +0000 Original-Received: (at 69405) by debbugs.gnu.org; 26 Feb 2024 17:10:20 +0000 Original-Received: from localhost ([127.0.0.1]:50078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reeUd-0001id-KO for submit@debbugs.gnu.org; Mon, 26 Feb 2024 12:10:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reeSn-0001b3-Ms for 69405@debbugs.gnu.org; Mon, 26 Feb 2024 12:08:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reeDc-0006vD-Ka; Mon, 26 Feb 2024 11:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3JqZrHYnsStWw7KALXWmDbjNuN/xzRe0j4a27H8pRVs=; b=L/fIIEAlf/hh6OzISsLX YyStoUdydlwnEzqVMhwIiQtwKb6AGanpswAp9p20Tj3Upy53yANMxJHU3M1IGrTXu1Q0kXgVd9ofb T1t34/I3fXPrNLZTZZolRNiW8FNxiNH4nzNq4WU9NDj1cBH3+AzSd/Etw4tGBv2DvDEB5WTjVA0+H g6hztfLGN9oHZJd2ZdK7M0qFADKH+YraWWBturWbOjotjC3wVB+1QMgv8Gn0fwZEvFC6lcf9YOhQM YI7kUhoef6PEfRTd/rkvBRG9rzqB1q7bCcot/L9VMcy4rG0RSAvSshLLCuI1jfls5ghwHtWdLHsUB jxfY93gziwyWeQ==; In-Reply-To: <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 26 Feb 2024 17:26:43 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280690 Archived-At: > From: Mattias Engdegård > Date: Mon, 26 Feb 2024 17:26:43 +0100 > Cc: 69405@debbugs.gnu.org, > casouri@gmail.com > > 26 feb. 2024 kl. 14.59 skrev Eli Zaretskii : > > > Can't we do that in the test harness, instead of introducing > > test-suite dependencies into the built Emacs binary? For example, how > > about adding to tree-sitter-extra-load-path in treesit-tests.el > > instead? > > Yes, that's probably a better idea. We don't even need anything in the test suites if we set `treesit-extra-load-path` in the Makefile, as in this patch. Right, thanks. This is much better. > (We could set an environment variable instead, but then it would need decoding in each tree-sitter test as well, and the change to the Makefile wouldn't really be simpler.) The question is how important is it to support cases where the directory is not under ~/.emacs.d/tree-sitter/, but somewhere else, perhaps created specifically for running the tests without affecting the production sessions? If that's not very important, then supporting just the HOME case should be enough.