From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69983: Use category for display-buffer-alist Date: Sun, 24 Mar 2024 19:19:16 +0200 Organization: LINKOV.NET Message-ID: <86h6gv7e0z.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: martin rudalics To: 69983@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 24 18:22:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1roRXj-0001DU-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Mar 2024 18:21:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1roRX9-0006rF-Ea; Sun, 24 Mar 2024 13:21:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roRX7-0006qa-Fx for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2024 13:21:21 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1roRX7-0000nQ-7a for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2024 13:21:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1roRXm-0004u4-1U; Sun, 24 Mar 2024 13:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: rudalics@gmx.at, bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Mar 2024 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69983 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: martin rudalics Original-Received: via spool by submit@debbugs.gnu.org id=B.171130089318737 (code B ref -1); Sun, 24 Mar 2024 17:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Mar 2024 17:21:33 +0000 Original-Received: from localhost ([127.0.0.1]:45354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roRXJ-0004s0-2c for submit@debbugs.gnu.org; Sun, 24 Mar 2024 13:21:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roRXG-0004rk-9I for submit@debbugs.gnu.org; Sun, 24 Mar 2024 13:21:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roRWa-0006mw-1G for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2024 13:20:48 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roRWX-0000m5-TK for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2024 13:20:47 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 52127240004 for ; Sun, 24 Mar 2024 17:20:42 +0000 (UTC) X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282024 Archived-At: 'display-comint-buffer-action' and 'display-tex-shell-buffer-action' are out of place in window.el, and they are redundant per se. What these variables are trying to achieve is already possible to do by using a 'category' in 'display-buffer-alist'. Here is an already supported example: #+begin_src emacs-lisp (add-to-list 'display-buffer-alist `(,(lambda (_buffer-name action) (eq (alist-get 'category action) 'comint)) (display-buffer-in-direction) (direction . top))) (display-buffer (get-buffer-create "blablabla") '(nil (category . comint))) #+end_src The advantage of this approach is removing a need of writing a complex regexp to match the buffer name. Using this approach it's possible just to mark all related callers with the same category, e.g.: diff --git a/lisp/cmuscheme.el b/lisp/cmuscheme.el index c84a1809322..ccd7f2f713f 100644 --- a/lisp/cmuscheme.el +++ b/lisp/cmuscheme.el @@ -238,7 +238,7 @@ run-scheme (inferior-scheme-mode))) (setq scheme-program-name cmd) (setq scheme-buffer "*scheme*") - (pop-to-buffer "*scheme*" display-comint-buffer-action)) + (pop-to-buffer "*scheme*" '(nil (category . comint)))) diff --git a/lisp/progmodes/inf-lisp.el b/lisp/progmodes/inf-lisp.el index 141bd18cf1e..1aa3bbd4239 100644 --- a/lisp/progmodes/inf-lisp.el +++ b/lisp/progmodes/inf-lisp.el @@ -308,7 +308,7 @@ inferior-lisp "inferior-lisp" (car cmdlist) nil (cdr cmdlist))) (inferior-lisp-mode))) (setq inferior-lisp-buffer "*inferior-lisp*") - (pop-to-buffer "*inferior-lisp*" display-comint-buffer-action)) + (pop-to-buffer "*inferior-lisp*" '(nil (category . comint)))) Or we need to keep backward-compatibility? Then the first step to deprecate there variables would be something like this: diff --git a/lisp/window.el b/lisp/window.el index bea050e181c..fa417817d1d 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -8912,7 +8944,7 @@ pop-to-buffer-same-window another window." (pop-to-buffer buffer display-buffer--same-window-action norecord)) -(defcustom display-comint-buffer-action display-buffer--same-window-action +(defcustom display-comint-buffer-action (append display-buffer--same-window-action '((category . comint))) "`display-buffer' action for displaying comint buffers." :type display-buffer--action-custom-type :risky t