From: Eli Zaretskii <eliz@gnu.org>
To: Ikumi Keita <ikumi@ikumi.que.jp>
Cc: 69187@debbugs.gnu.org, arash@gnu.org, johnw@gnu.org
Subject: bug#69187: 29.2; Poor compatibility in align.el
Date: Sat, 06 Apr 2024 14:03:29 +0300 [thread overview]
Message-ID: <86h6ge3g8u.fsf@gnu.org> (raw)
In-Reply-To: <2364.1712395849@localhost> (message from Ikumi Keita on Sat, 06 Apr 2024 18:30:49 +0900)
> From: Ikumi Keita <ikumi@ikumi.que.jp>
> cc: 69187@debbugs.gnu.org, John Wiegley <johnw@gnu.org>
> Comments: In-reply-to Eli Zaretskii <eliz@gnu.org>
> message dated "Sat, 06 Apr 2024 09:21:18 +0300."
> Date: Sat, 06 Apr 2024 18:30:49 +0900
>
> >>>>> Eli Zaretskii <eliz@gnu.org> writes:
> > Please explain the issue in more detail and in terms that someone who
> > doesn't use AUCTeX and has only superficial understanding of align.el
> > can understand and reason about.
>
> > Three questions that pop up immediately, perhaps because I'm missing
> > something:
>
> > . why not use derived-mode-p instead of 'equal' in the run-if form
>
> That's what I thought. Arash and I are proposing to _remove_ the run-if
> form so that `derived-mode-p' in `align-region' would do the expected
> job.
>
> > (and why remove it in the first place)?
>
> See above.
>
> > . what is the rationale for not using align-tex-modes here, only
> > latex-mode?
>
> Because the current `tex-tabbing-separator' entry in `align-rules-list'
> excludes other modes by `run-if' form. I'm just following that behavior
> for AUCTeX modes. As I said in my previous message, this isn't much
> relavant; using `align-tex-modes' instead of '(latex-mode) would almost
> be the same for practical usage, provided that the `run-if' form is
> removed.
>
> > . why not just add the new LaTeX-mode to the list in
> > align-tex-modes, so that people who use an old AUCTeX will not
> > have their align rules broken?
>
> That isn't necessary. Only `latex-mode' is needed there because
> `derived-mode-p' considers that `latex-mode' is parent of `LaTeX-mode'.
> However, the current `run-if' form excludes `LaTeX-mode' because if uses
> `eq', not `derived-mode-p'.
Then I'm okay with installing the proposed change.
next prev parent reply other threads:[~2024-04-06 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 12:03 bug#69187: 29.2; Poor compatibility in align.el Ikumi Keita
2024-02-18 19:02 ` Ikumi Keita
2024-04-03 12:22 ` Arash Esbati
2024-04-05 16:57 ` Ikumi Keita
2024-04-05 19:59 ` Arash Esbati
2024-04-06 6:21 ` Eli Zaretskii
2024-04-06 9:30 ` Ikumi Keita
2024-04-06 11:03 ` Eli Zaretskii [this message]
2024-04-06 20:14 ` Arash Esbati
2024-04-07 5:49 ` Eli Zaretskii
2024-04-07 8:49 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6ge3g8u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69187@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=ikumi@ikumi.que.jp \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).