From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode Date: Sun, 02 Jun 2024 06:15:48 +0530 Message-ID: <86h6ecjhoj.fsf@outlook.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17487"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org To: 71314@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 02 02:47:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDZNW-0004Jl-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jun 2024 02:47:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDZN8-00024H-0H; Sat, 01 Jun 2024 20:46:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZN5-000236-O4 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:46:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDZN5-0007rJ-C6 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:46:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDZNG-0005qf-NA; Sat, 01 Jun 2024 20:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2024 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71314 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: larsi@gnus.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171728917322407 (code B ref -1); Sun, 02 Jun 2024 00:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 00:46:13 +0000 Original-Received: from localhost ([127.0.0.1]:57570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMT-0005pK-CE for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMS-0005pC-3W for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMF-0001sf-KP for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMD-0007mH-M7 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717289153; x=1717893953; i=jimjoe@gmx.net; bh=nUVFbwAMRuoFtL0xYGowI0lOeWcD17zKE3rWjzPNSZY=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=fCPt0qTAxQjS1pYjetaV5Em6/bgKcSQJeKyWk6BHdu3BiNZ7iPiZL3VMxhZIXW+U ku5SWn8NugnzmpkRB8YGwD1cIpjLPhutMQEgvxivl1MbrNSi2soy+Zq5p5DqSqYwy EDaEYUc7d2FzPak5/pgJRfLv8RlQwlFN5hD4V3KuFbUjnD3HfN6hP5TWvUxJVLokT mX+OYpy2lpe1HNKwb2OuuJYivhYNxsBHlnZEaEOR5qpol8vNlErhQDDMLPcAOdGmF OqfEqUf+vQ3VUXviovTbQi6uYsJpD7Ty7yt5tTSAec2fhoby35Hli5BsFQzDxJHwc VSW7ZiG0dhdrckwy5A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([59.92.166.156]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MLzFr-1rvcxt2I09-00LC9q for ; Sun, 02 Jun 2024 02:45:53 +0200 X-Provags-ID: V03:K1:bahAiiOF85t+kjzjkbZ4uTsFzb7P9TfmI9G6X33Ur+bqZCInRYq u/TJsAq1Yakvdg3TSj1+q7cHz8EhzmjNyseQBfjkLP1xqqGoscKuHqiU1CHXigdmTiEmzP/ sbOU04I3UQPRivURhGKJ/q4KldPdw/Evv1Uvd+98E+xZunt/10c2cdH8SGEaeRGYIVc9pD8 xnQeyx8DWZlB+i62z/+Xg== UI-OutboundReport: notjunk:1;M01:P0:SzHI30cnWCs=;2op9LHN/PEwSthpLzSXMviFnmFp m5C8xbufVwOAodWDJXHeGkrOP4azWBUD+lS+2K7brWFKEK2QpbJJHihgGzUqKJ+th6Mjd+Qwh bOtsyZvw1jOVCcJE7XaPt5JrbF8mkdYLLfoiF+kLUnP7/PJg2VP+PimiLSt3xFpV+gdXUea82 04egw9llDaUGVhH9LHjaV/GYhin84Tp/JEMi14MHzZV+Obn45rxiiuUHQmgnitoiABZ14fjZ0 0h+DLphn+QfPW5wPL5OT6mlEQuYovuAivdgCD6ojZgTAU9Y+b/GrwTPy76mgQ66oNVFjUjKMK HQJ40jrQctur34hk3p0VuE73BeZPUIy0OZnR53/OKkm7jNDggULLoq2q/fGCwK4JbCl21H6FU 5vH8bMKPQtnGmATJ/9yA0za1mfbTNozxp4t1o3xsT2JXj/VCewghvwlAp1oCIy3T8tMbd8seH fdWF4fdwn8aRFDRstQNG/uOapA4DaEUuWwUELIFq3LJGQ0xOSjkoZ0Aw/qNiFuVwm2dgoEs6L ur0PYd3iraklb6lxBHU92EihwyrRpl8rtWMxAqPvJRY/KczPAt+wsn/iHWXo/YCjMRzhZmPQk KkmDZUInUxxd/ICh+yVNyfzamtYgCcHN6u329n8AFJCLQZlG6uLscyZtp3fBTRm5GObVSook7 RDYaADA/5kXycAb5ovobirNlHFMYbNkVBfRWigm5LfE1WYnqXPrmhP38u+emBjTcweka0Qlar SW/MDgiTmZNE27CiHpyKWCestes5OZ2l7bNjC1Szj72aLJvl1Fq/U/wLvG7UqTVBq4IEDF8H Received-SPF: pass client-ip=212.227.15.18; envelope-from=jimjoe@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286350 Archived-At: --=-=-= Content-Type: text/plain - Make sure python info docs are installed (in Debian-derivatives, 'sudo apt install python3-doc') - emacs -Q - Open a buffer test.py and type: print - C-h S fails, even after typing RET, but... - Then do info-lookup-reset, and the previous step works. Here's a possible patch, which hasn't been tested as much as needed: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-for-doc-spec-function-early--in-interactive.patch Content-Description: [PATCH] Check for doc-spec-function early, in interactive Content-Transfer-Encoding: quoted-printable =46rom 81b3a7b0c2be3c974729d1a4ffc44351d5393a45 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sun, 2 Jun 2024 05:59:35 +0530 Subject: [PATCH] Check for doc-spec-function early, in interactive * lisp/info-look.el (info-lookup-interactive-arguments): Move here. (info-lookup): From here. =2D-- lisp/info-look.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/info-look.el b/lisp/info-look.el index cd59fdf17d7..2baf133c7d3 100644 =2D-- a/lisp/info-look.el +++ b/lisp/info-look.el @@ -327,8 +327,11 @@ info-lookup-interactive-arguments If optional argument QUERY is non-nil, query for the help mode." (let* ((mode (cond (query (info-lookup-change-mode topic)) - ((info-lookup->mode-value topic (info-lookup-select-mode)) - info-lookup-mode) + ((when-let + ((info (info-lookup->mode-value + topic (info-lookup-select-mode)))) + (info-lookup--expand-info info)) + info-lookup-mode) ((info-lookup-change-mode topic)))) (completions (info-lookup->completions topic mode)) (default (info-lookup-guess-default topic mode)) @@ -404,9 +407,6 @@ info-lookup different window." (or mode (setq mode (info-lookup-select-mode))) (setq mode (info-lookup--item-to-mode item mode)) - (if-let ((info (info-lookup->mode-value topic mode))) - (info-lookup--expand-info info) - (error "No %s help available for `%s'" topic mode)) (let* ((completions (info-lookup->completions topic mode)) (ignore-case (info-lookup->ignore-case topic mode)) (entry (or (assoc (if ignore-case (downcase item) item) completi= ons) =2D- 2.40.1 --=-=-= Content-Type: text/plain -- --=-=-=--