From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73584: 29.3; read-key Date: Wed, 02 Oct 2024 13:50:55 +0300 Message-ID: <86h69u22y8.fsf@gnu.org> References: <56f7ea1fff72be793a8026baf34e1548@jovi.net> <86v7yb11wc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73584@debbugs.gnu.org, Emacs-hacker2023@jovi.net To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 02 12:52:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svwxt-00069L-Ou for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Oct 2024 12:52:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svwxg-0006PN-I1; Wed, 02 Oct 2024 06:52:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svwxe-0006P9-5v for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:52:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svwxd-0003nV-TU for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=6P08YuHmdxHVAkRM0LIiAZs/qL6Dd2R8RIimoU15NWc=; b=t7IvB4SbmH1FsNSCDvLpQM9M9idCR7qh0PKeBoJjSNrs/ugBkQIgUuLu4raakxvsa6brmn3zc73aEF0RWwPZaMlZGimJIshc8PNMoX5XzvsS4ScIVJCDvCdtehlsTIGlHyKA+N+IaRLaU/jf5p7AQfl6Qf/TiCMZT0UTASY3oW12+csBVgbwPY/gToQcT3Nu4p/R14SvCekI5yB8zTGHfe4RiWHzKuuUHkC4GUOaNnBVt9/1H2pwxcLPs4bbcb6HPn9rof+o6cg6YPCkm8mWYYUbWxWdE2GMtImwAamnOUQcP2C5s3IneFSwwI2DEFwbu87+iZxj/GAqJuXm80Td/w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svwxd-0008Uh-VA for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2024 10:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73584 X-GNU-PR-Package: emacs Original-Received: via spool by 73584-submit@debbugs.gnu.org id=B73584.172786628032568 (code B ref 73584); Wed, 02 Oct 2024 10:52:01 +0000 Original-Received: (at 73584) by debbugs.gnu.org; 2 Oct 2024 10:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:56735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svwwy-0008TE-2v for submit@debbugs.gnu.org; Wed, 02 Oct 2024 06:51:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svwww-0008Sz-9I for 73584@debbugs.gnu.org; Wed, 02 Oct 2024 06:51:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svwwl-0003Xu-0T; Wed, 02 Oct 2024 06:51:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6P08YuHmdxHVAkRM0LIiAZs/qL6Dd2R8RIimoU15NWc=; b=opGFWoTTuHqm r/FVfxzsItEJuTBBh/S6LiS+ZD+1Tugs1XT/Jgb+WEboJ1oPm/C0BL6t5TS/z0Ackfa65Z9WsYnB2 AIklGXNgN+fZfaow93b3PIjQ5I+g+H52ZUQT53VAgohkre7Y2rsW7EThD1PCY3jwjJcdj772g7ScU d/cBT8tcEt/FkReuo5bPJBSNLONG5QVBDMMESE0NqCn/CDibSampbc4QmLBikdemMtkzbMIBl0Wdd qFNAKb7g276ynYsHy6Y/xRMYL99qXO6kutMAHj1wlqwENwhHkZBok0xR8vSfGUSxyAQVipn1RM/j4 huddXuQVj920oBNL5bHm4A==; In-Reply-To: (message from Stefan Kangas on Wed, 2 Oct 2024 10:02:44 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292833 Archived-At: > From: Stefan Kangas > Date: Wed, 2 Oct 2024 10:02:44 +0000 > Cc: 73584@debbugs.gnu.org > > Eli Zaretskii writes: > > >> Date: Tue, 01 Oct 2024 13:21:11 -0500 > >> From: Devon Sean McCullough > >> > >> (read-key 0) jails Emacs in a null keymap. > > > > You should be able to escape the jail with ESC or C-[. > > > > I don't see a bug here. > > It would arguably be a bit nicer to signal the error early to avoid > having to mash C-[: Maybe. But what exactly is wrong with signaling the error from read-key-sequence-vector, which read-key calls? > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -3307,6 +3307,8 @@ read-key > what you want as `read-key' temporarily removes all bindings > while calling `read-key-sequence'. If nil or unspecified, the > only unbound fallback disabled is downcasing of the last event." > + (or (stringp prompt) > + (signal 'wrong-type-argument (list 'stringp prompt))) This will signal an error if PROMPT is nil or omitted, which we definitely must support. > ;; This overriding-terminal-local-map binding also happens to > ;; disable quail's input methods, so although read-key-sequence > ;; always inherits the input method, in practice read-key does not > > BTW, do we have something like `cl-check-type' outside of cl-lib? We shouldn't use any cl stuff in subr.el, surely?