From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version. Date: Fri, 18 Oct 2024 09:51:13 +0300 Message-ID: <86h699oqe6.fsf@gnu.org> References: <2520493.XAFRqVoOGU@fedora> <86a5f8vbro.fsf@gnu.org> <26655922.1r3eYUQgxm@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73779@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 18 08:52:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1gqJ-0009DO-Ux for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Oct 2024 08:52:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1gpu-0003XL-4H; Fri, 18 Oct 2024 02:51:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1gpp-0003X2-Db for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 02:51:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1gpo-0007mR-FO for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 02:51:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=kmHVEF+z4h/OybfdFhmMVQgLKBxBgY/MRbflLiDb3RI=; b=p3MQqQh6JVRa7rM5Pb5CHWjHOiStBt8dtl0lm4RtFIM4M2immpYuU5n3St6ntfeHdsEsr38FEXuCcpY5NW6Xw0lxPhh8F4p1Ss1+iyg2UwdxVhqkP5omPlIVGaSeodbVK8aMWZveOr8vVY4lwNCoknWKtzZV0jugj98bG+a+QETXXc8j6B3sToSioidVAkof32GQuXEMMv+u+vETMhpxdeRxPeOT55HufemrKPOJheLOSFy21KOgJJNEbew9G80k9k+t8JQWaqJ8j7K4qxJCCCFLnTUbmmpDDG2voX1KfTxy32MX/aqyh5B2IqbJarko1HwUA4hK7rtC794FCga7SQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1gqA-0006SF-33 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 02:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2024 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73779-submit@debbugs.gnu.org id=B73779.172923430524776 (code B ref 73779); Fri, 18 Oct 2024 06:52:02 +0000 Original-Received: (at 73779) by debbugs.gnu.org; 18 Oct 2024 06:51:45 +0000 Original-Received: from localhost ([127.0.0.1]:36821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1gpt-0006RY-3u for submit@debbugs.gnu.org; Fri, 18 Oct 2024 02:51:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1gpq-0006RH-TW for 73779@debbugs.gnu.org; Fri, 18 Oct 2024 02:51:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1gpP-0007g7-Gf; Fri, 18 Oct 2024 02:51:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kmHVEF+z4h/OybfdFhmMVQgLKBxBgY/MRbflLiDb3RI=; b=nrFFcWFIgx0T F61dImEJDTDpzbKqmrNv60hBAV5Dh9HZUU+hcRVKAyYySKEo4ybtX1jTf6PHQp4prMIiSODRp16fc C/QylEeh8qyokf7nFDpMvg4Ny3pce/XlUzvBrRNf4nnSZBqECfpde+CfhNlBRaPfRUzrRCd5elSxq cnvFIA1nWSmdhfMk09KzkiQHseT4qk2Zrdjkc84kFIHahB8IS2eoG2L5DwxdyboEK/iiAs0+CNGXu kJlcco94JAvy9Mqkj1AqZuzlXK+O+8Qh1JXOy2O7kvZFdnAkdiDCP9drDaKwmIgjyXjH7ts0FQmbk WvsZraCFIVCGo5/MacbkAw==; In-Reply-To: <26655922.1r3eYUQgxm@fedora> (message from Vincenzo Pupillo on Sun, 13 Oct 2024 11:19:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293766 Archived-At: > From: Vincenzo Pupillo > Cc: 73779@debbugs.gnu.org > Date: Sun, 13 Oct 2024 11:19:31 +0200 > > > I have two questions about this: > > > > . will the code which uses the "asymmetric property visibility" also > > work without problems with versions of the grammar library before > > 0.23.3? > > Yes, I tested it with older versions of the grammars. > 'php-ts-mode--test-visibility-modifier-operation-clause-p' is used to check if > this new feature is defined or not, and behaves accordingly. > > > . do you consider the code changes to be tested well enough and thus > > safe to be installed on the emacs-30 release branch? > > > Yes, I've been using this patch at work for about a week and haven't had any > problems. I was about to install this, but byte-compiling the modified file yields the following warnings: ELC progmodes/php-ts-mode.elc In php-ts-mode--open-statement-group-heuristic: progmodes/php-ts-mode.el:435:58: Warning: Unused lexical argument `parent' progmodes/php-ts-mode.el:499:50: Warning: argument `_bol' not left unused progmodes/php-ts-mode.el:518:56: Warning: argument `_bol' not left unused Could you please fix these and resubmit the patch?