From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Sun, 20 Oct 2024 07:58:21 +0300 Message-ID: <86h697jrpu.fsf@gnu.org> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> <86r08enfri.fsf@gnu.org> <87cyjyvsns.fsf@melete.silentflame.com> <868qulojrx.fsf@gnu.org> <87zfn1vjvb.fsf@melete.silentflame.com> <864j59ob91.fsf@gnu.org> <87ldyjvbgz.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, dmitry@gutov.dev To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 07:02:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2O4o-00010c-DX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 07:02:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2O4R-000390-9K; Sun, 20 Oct 2024 01:01:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2O4Q-00038r-8L for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 01:01:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2O4P-0005yC-Vq for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 01:01:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=XE4B8A1kRwFBXSZZ01krgqCXtl8a+Bn1SKsLNqJzrgQ=; b=EycF6VS9sbY+QYxkEj5DBtBdpaU+2xfYTiW91lGERePXZz0QnQVTnEqhNmQINmoe9YaSN/sn0MLaumwgagkcvpQ3U/FO7j9Fikb/lOLpVS3imFSsTdXz0DeqzlaZ8veKqqAyOG1nvoxgNiv/dqI1svt2T2FhSgFPkLMJ/N+VcTHS0ngdiWuN7PQyevSoaP2hlQAhxhBhRZMpEcZqZIoSGI9q2WZgq9WXOGjV7b+s9X/ynCNq91Aw0kpVRZD991xEnGZcICf+++8xTLz3EYzoSOZXbVRDm2uMruj5hm6JVkb9UUR7T4jm87aRl7Rc2ZkAf4n0wFWmtp70qKYTzeiSzQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2O4n-0000rP-Ks for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 01:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 05:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.17294004673235 (code B ref 64055); Sun, 20 Oct 2024 05:02:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 05:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:45438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2O3v-0000q7-4U for submit@debbugs.gnu.org; Sun, 20 Oct 2024 01:01:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2O3s-0000pQ-MS for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 01:01:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2O1H-0005hj-9s; Sun, 20 Oct 2024 00:58:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XE4B8A1kRwFBXSZZ01krgqCXtl8a+Bn1SKsLNqJzrgQ=; b=LGf96zAQWgMA 8Kxx8jyl06I2dm90OCehJLHx/pzFO4fn+j7JIkpH08L6nqkJbaePK/Bhn1ZFVsrmFzF1lTOQguFVr lUAkqENuh8R5FiUibNRbRWbwq+kpjDeiPTGbwBBvOr1ZRnyeJ9vq2RkViJlnu5crbceiOK7N4X76P 9t3XyWs8oIPXObqcTaIxmNlW1OlbcuZD6hraDHH2wDWlGshYygfZG3NbFTxDmcWv6fRcuZ5KO8rzh o8HZ2LZJcxU/8D4MszMQNSJ77LRMSOGjJv7dcrrC4GjsaPU/mlBf9xPD1vww11sCG9M7vnM/YbdqY Kr/EuMT/W+Nd9GFvhbFWaA==; In-Reply-To: <87ldyjvbgz.fsf@melete.silentflame.com> (message from Sean Whitton on Sun, 20 Oct 2024 08:56:12 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293925 Archived-At: > From: Sean Whitton > Cc: 64055@debbugs.gnu.org, Morgan.J.Smith@outlook.com, rpluim@gmail.com, > dmitry@gutov.dev > Date: Sun, 20 Oct 2024 08:56:12 +0800 > > On the other hand, the design principle doesn't apply directly to the > new get-change-comment backend action, because src, rcs, sccs, cvs and > svn do not *require* an implementation of get-change-comment in order > for the log-view-modify-change-comment command to work, so far as I > understand it -- otherwise the feature would not have been implemented > the way it is, or we'd have bug reports. > > Git, I think, does require an implementation of get-change-comment, or > at least, I concluded that it's the most natural way to implement > log-view-modify-change-comment for git. It is this difference between Git and the rest that I don't yet see, and you didn't explain it, just stated its existence. Why is the method necessary for Git, but not for other VCSes? they all produce similar displays of log messages, complete with Author, Date, etc., and so the difficulties of extracting just the change log message should affect all of them, no?